New issue
Advanced search Search tips

Issue 892145 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Nov 14
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 893522



Sign in to add a comment

Dynamic Type: Omnibox font size isn't scaling up

Project Member Reported by gambard@chromium.org, Oct 4 
With large fonts.

What steps will reproduce the problem?
1. Open a WebPage
2. Focus the omnibox

What is the expected result?
The text should be scaled up, in step 1 and 2.

What happens instead?
The font size is the same, when the omnibox is focused and unfocused.

Comment 1 by gambard@chromium.org, Oct 9

Blocking: 893522
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea0b21a4705d1e28f3c425415e422e08fa2495bd

commit ea0b21a4705d1e28f3c425415e422e08fa2495bd
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Oct 10 17:23:11 2018

[iOS] Move DynamicType multipler chooser to helper

This CL moves the function to get the multiplier to be applied to font
to get the font size preferred by the user to a util file.
Having it in a separate util file allows this function to be used in
other parts of the app.

Bug:  892145 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2e3e0e2eaaa89e8735b1501c2e6a726cbab5424b
Reviewed-on: https://chromium-review.googlesource.com/c/1264598
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598382}
[modify] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/ui/util/BUILD.gn
[add] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/ui/util/dynamic_type_util.h
[add] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/ui/util/dynamic_type_util.mm
[add] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/ui/util/dynamic_type_util_unittest.mm
[modify] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/web/font_size_tab_helper.mm
[modify] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/ios/chrome/browser/web/font_size_tab_helper_unittest.mm
[modify] https://crrev.com/ea0b21a4705d1e28f3c425415e422e08fa2495bd/tools/metrics/histograms/histograms.xml

Comment 3 by gambard@chromium.org, Oct 15 

The font size and the toolbar height shouldn't increase for the biggest two preferred content size categories.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/718581c2bb1da0b634ea736211624344564997ea

commit 718581c2bb1da0b634ea736211624344564997ea
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Oct 17 17:01:04 2018

[iOS] Don't pass the font to the OmniboxTextField

This CL changes the OmiboxTextField. Now the fonts aren't passed in the
constructor. Instead they are configured internally.

Bug:  892145 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2e8caa8c2cba4b276cfd2189f4a865fd70d4496b
Reviewed-on: https://chromium-review.googlesource.com/c/1286657
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600435}
[modify] https://crrev.com/718581c2bb1da0b634ea736211624344564997ea/ios/chrome/browser/ui/omnibox/omnibox_container_view.h
[modify] https://crrev.com/718581c2bb1da0b634ea736211624344564997ea/ios/chrome/browser/ui/omnibox/omnibox_container_view.mm
[modify] https://crrev.com/718581c2bb1da0b634ea736211624344564997ea/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.h
[modify] https://crrev.com/718581c2bb1da0b634ea736211624344564997ea/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/718581c2bb1da0b634ea736211624344564997ea/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a056c55765a5def12a8c55c592a16f45fd9ca42

commit 0a056c55765a5def12a8c55c592a16f45fd9ca42
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Oct 25 15:33:20 2018

[iOS] Change the layout of FindBar

This CL changes the layout of the FindBar so it is displayed on top of
the toolbar on iPhone. Previously it was displayed below the safe area
and with a fixed height. Now it is covering the toolbar.

Bug:  892145 
Change-Id: I06aac98ad9396373a78bbd3fb4fb8691e6a2a82b
Reviewed-on: https://chromium-review.googlesource.com/c/1290971
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602715}
[modify] https://crrev.com/0a056c55765a5def12a8c55c592a16f45fd9ca42/ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9

commit 84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 06 08:58:55 2018

[iOS] Have toolbar height based on preferred font size

This CL changes the height of the toolbar such as its height is now
multiplied by a factor depending on the preferred font size specified
by the user.

Bug:  892145 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If757cf7fd7843ce1a61b3748f653c2c27347e11e
Reviewed-on: https://chromium-review.googlesource.com/c/1286651
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605633}
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/BUILD.gn
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm
[add] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/toolbar_utils.h
[add] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/toolbar/toolbar_utils.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/util/dynamic_type_util.h
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/util/dynamic_type_util.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/util/dynamic_type_util_unittest.mm
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/util/uikit_ui_util.h
[modify] https://crrev.com/84dd6c2439a6cc2bf7765b279f6c69e05b6a1dd9/ios/chrome/browser/ui/util/uikit_ui_util.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3bf809a3d75c3456f73e6fbb36ced02edc05dc2

commit d3bf809a3d75c3456f73e6fbb36ced02edc05dc2
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 06 10:54:47 2018

[iOS] Update view on DynamicType changes

This CL marks the WebState's view as dirty when the preferred content
size is changed. It causes the view to be laid out again.
It also changes the way the Overscroll controller is getting its
initialHeaderInset, by asking it to the delegate every time instead of
caching it, as the value become stale after changing the preferred
content size.

Bug:  892145 
Change-Id: I2fe0b54a107e0cfed438ea5c57efdbb65fe4c5a3
Reviewed-on: https://chromium-review.googlesource.com/c/1307443
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605645}
[modify] https://crrev.com/d3bf809a3d75c3456f73e6fbb36ced02edc05dc2/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm
[modify] https://crrev.com/d3bf809a3d75c3456f73e6fbb36ced02edc05dc2/ios/web/web_state/ui/crw_web_controller_container_view.mm

Comment 8 by gambard@chromium.org, Nov 13

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1

commit e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Nov 14 13:16:36 2018

[iOS] Fix toolbar issues with Dynamic Type

This CL fixes few issues with Dynamic Type in the toolbar:
- The steady view label is cut and wrongly positionned in fullscreen.
- The location bar isn't pill shaped.
- The incognito ntp's top icon can be cut out by the toolbar.

Bug:  892145 
Change-Id: Ic9c35f593bf776cc506661da35a786ed584ae6fb
Reviewed-on: https://chromium-review.googlesource.com/c/1333392
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607967}
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view.mm
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/ntp/BUILD.gn
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/toolbar/primary_toolbar_view.mm
[modify] https://crrev.com/e2e107ca072b75f9df90bc1bd6287c3eb05d9ca1/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm

Comment 10 by gambard@chromium.org, Nov 14

Status: Fixed (was: Started)
►

Sign in to add a comment