New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892137 link

Starred by 1 user
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Nov 13
Cc:
danakj@chromium.org
█ fsam...@chromium.org
ericrk@chromium.org
piman@chromium.org
chelamcherla@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Graphics glitches while scrolling Android M69

Project Member Reported by kylec...@chromium.org, Oct 4 
There are some glaring graphics glitches while scrolling on my Nexus 5X with M69 stable. See the attached video for an example. 

Chrome Version: 69.0.3497.100 (Official Build) (32-bit)
OS: Android
Device: Nexus 5X

What steps will reproduce the problem?
(1) Visit https://www.fourall.ca/shop
(2) Scroll from top to bottom of page
(3) Random repeated textures show up while scrolling.

Graphics Feature Status
Canvas: Hardware accelerated
Flash: Hardware accelerated
Flash Stage3D: Hardware accelerated
Flash Stage3D Baseline profile: Hardware accelerated
Compositing: Hardware accelerated
Multiple Raster Threads: Disabled
Native GpuMemoryBuffers: Software only. Hardware acceleration disabled
Out-of-process Rasterization: Disabled
Hardware Protected Video Decode: Unavailable
Rasterization: Hardware accelerated
Skia Deferred Display List: Disabled
Skia Renderer: Disabled
Surface Synchronization: Disabled
Video Decode: Hardware accelerated
Viz Service Display Compositor: Disabled
WebGL: Hardware accelerated
WebGL2: Hardware accelerated

Finch Experiments:
AndroidInProductHelpDataSaverDetail-Enabled
AndroidInProductHelpDataSaverPreview-Enabled
AndroidInProductHelpDownloadHome-Enabled
AndroidInProductHelpDownloadInfoBarDownloadContinuing-Default
AndroidInProductHelpDownloadInfoBarDownloadsAreFaster-Default
AsyncDns-Enabled
AsyncNavigationIntercept-Default
AutofillDeleteDisusedData-Enabled
AutofillResetFullServerCardsOnAuthError-Enabled
AutofillSmallFormSupport-Default
ChromeChannelStable-Enabled
ChromeDuet-Default
ChromeModern-Modern_Launch
ChromeSurvey-Enabled
ClearTabsIPH-Enabled
ContextualSearch-Default
DataCompressionProxyHoldback-Disabled
DataCompressionProxyPromoVisibility-EnabledWithSnackbarPromoNonEM
DataReductionProxyServerExperiments-DefaultBehavior
DataSaverSiteBreakdownUsingPageLoadMetrics-Default
DefaultEnableOopRasterization-Control3
DelayRequestsOnMultiplexedConnections-Enabled_NoControl
DownloadsLocationChange-Default_V2
ExpiredHistograms-ExpiredHistogramLogicEnabled
ExploreOnContent-Default
FrameTypePriorityExperiment-Default
FrameTypePriorityExperiment2-Default
HorizontalTabSwitcherAndroid-Default
LowPriorityIframes2-Control
MetricsAndCrashSampling-OutOfReportingSample
ModernMediaControls-Default
NTPArticleSuggestionsExpandableHeader-Enabled
NTPFaviconsFromNewServer-Enabled
NetworkQualityEstimator-Disabled
NewTabPage-Default
NoSearchDomainCheck-Default2
OfflinePagesCctV2-Enabled
OfflinePagesSharing-Enabled
OmniboxBundledExperimentV1-ChromeAndroidPSuggestAndPhysWebAndMore_PostPeriod
Previews-Enabled_NoControl
PreviewsNoScript-Enabled
QUIC-EnabledNoId
ReportingAPIAndNetworkErrorLogging-ReportingAndNELEnabled
ResourceLoadScheduler-Enabled_Launch
SafeBrowsingAdSamplerTrigger-AdSampler_NormalRate2
ScrollAnchorSerialization-Enabled
ServiceWorkerPaymentApps-Enabled
ServiceWorkerServicification-Default2
SimplifiedNTP-Enabled_NoScrollToLoad
StopNonTimersInBackground-Enabled
TLS13Variant-EnabledV4
ThrottleDelayable-Default
TranslateRankerModelAndroid-Enforcement20170918Launched
TranslateUserEvents-Default
UKM-Enabled_20180314
UMA-Population-Restrict-normal
UMA-Uniformity-Trial-1-Percent-group_58
UMA-Uniformity-Trial-10-Percent-group_01
UMA-Uniformity-Trial-100-Percent-group_01
UMA-Uniformity-Trial-20-Percent-group_01
UMA-Uniformity-Trial-5-Percent-group_05
UMA-Uniformity-Trial-50-Percent-default
UnifiedAutoplay-DefaultEnabled
V8CacheInlineScriptCode-Default
VizHitTestDrawQuad-Default
android_scrolling_glitches.MOV
1.4 MB View Download

Comment 1 by chelamcherla@chromium.org, Oct 5

Cc: chelamcherla@chromium.org
Labels: Needs-triage-Mobile Triaged-Mobile Needs-Feedback
 kylechar@: Tested this issue on 69.0.3497.100 using Nexus 5 and unable to reproduce the issue. Not observing any glitches [as shown in video] on scrolling but observing black screen near header region. Please check the attcahed screencast and let us know if this is the issue you are addressing.

Thanks!
892137.mp4
20.1 MB Download

Comment 2 by kylec...@chromium.org, Oct 11 

chelamcherla: Your video looks fine, the tiles aren't finished rasterizing yet and it's showing the background color instead.

Comment 3 by ericrk@chromium.org, Nov 9

Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
over to me to try to repro.

Comment 4 by kylec...@chromium.org, Nov 9 

I could only get this to repro on a Nexus 5X btw. I also tried it on a Nexus 5, Pixel C and Pixel 2 with no success. I can check if it still repros on the phone later today (it's at home) if you're unable to repo.

Comment 5 by ericrk@chromium.org, Nov 10 

I can repro on 70.0.3538.80. Bisecting now.

Comment 6 by ericrk@chromium.org, Nov 12

Status: Started (was: Assigned)
Not a regression, but narrowed things down a bit:

We are checkerboarding, but the checkers that we encounter are transparent, leading to us seeing through to the uninitialized area below the tiles.

We can fix this with a change like this:
https://chromium-review.googlesource.com/c/chromium/src/+/1331633

But this isn't really a "good" solution, so I'll look at why we are getting transparent values from SafeOpaqueBackgroundColor().

Comment 7 by ericrk@chromium.org, Nov 12

Owner: chrishtr@google.com
chrishtr@ helped me debug - it looks like this is because we're treating a layer as opaque, even when BackgroundTransfersToView(). Over to Chris for a fix.

Comment 8 by chrishtr@chromium.org, Nov 13

Owner: chrishtr@chromium.org
Correction on fix - the bug is actually that we shouldn't recurse to children in
the presence of a foreground layer.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bda6e124f6ffff2a67c32d2e65903a2c25334430

commit bda6e124f6ffff2a67c32d2e65903a2c25334430
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Tue Nov 13 19:00:34 2018

[PE] Fix contents opaque for composited layers in the presence of a foreground layer

The foreground layer paints normal-flow and positive z-index non-composited
children in the presence of a composited negative-z-index-child. In these cases,
we should not consider the normal-flow or positive z-index non-composited children
as contributing to opaqueness of the main graphics layer, since they paint
elsewhere.

Bug:  892137 

Change-Id: I7bd6a4eab615881e4ec3931049f292b046202430
Reviewed-on: https://chromium-review.googlesource.com/c/1332699
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607683}
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/paint/paint_layer_test.cc
[modify] https://crrev.com/bda6e124f6ffff2a67c32d2e65903a2c25334430/third_party/blink/renderer/core/testing/core_unit_test_helper.h

Comment 10 by chrishtr@chromium.org, Nov 13

Status: Fixed (was: Started)

Comment 11 by kgna...@chromium.org, Nov 15 

Tested on: 72.0.3610.2. Nexus 5X / 8.1.0

There is no Scrolling glitches, but black patch is observed while scrolling the page . Attached the video of the behavior, please take a look.
scroll_blackpatch.mp4
25.0 MB Download

Comment 12 by chrishtr@chromium.org, Nov 15 

This latest problem is because the image assets are 4000px in each direction, 
and due to CSS that clips them, a GPU raster optimization to downsample is
turned off. ericrk@ is going to fix that separately.
►

Sign in to add a comment