[2096/2653] LINK host/protoc
FAILED: host/protoc 
python "../../../../../../chromeos/assistant/libassistant/src/build/toolchain/gcc_link_wrapper.py" --output="host/protoc" -- /b/swarming/wTqTnh1/ir/cache/cbuild/repository/.cache/distfiles/target-master/chrome-src-internal/src/third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=gold -B../../../../../../chromeos/assistant/libassistant/src/third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -Wl,-O2 -Wl,--gc-sections -Wl,--gdb-index -rdynamic -nostdlib++ -Wl,-rpath-link=host -Wl,--disable-new-dtags -static-libgcc -o "host/protoc" -Wl,--start-group @"host/protoc.rsp"  -Wl,--end-group   -ldl -lpthread -lrt 
/usr/bin/ld.gold: warning: ignoring --threads: /usr/bin/ld.gold was compiled without thread support
/usr/bin/ld.gold: warning: ignoring --thread-count: /usr/bin/ld.gold was compiled without thread support
/usr/bin/ld.gold: error: treating warnings as errors
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "../../chromeos/assistant/internal/build_libassistant.py", line 173, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../chromeos/assistant/internal/build_libassistant.py", line 164, in main
    subprocess.check_call(args)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', 'obj/chromeos/assistant/internal', 'libassistant.so']' returned non-zero exit status 1
[15793/45962] CXX obj/services/resource_coordinator/public/mojom/mojom_blink/lifecycle.mojom-blink.o

+xiaohuic

xiaohuic: Any thoughts?

+yunlian

yunlian: Since you worked on assistant before do you have any ideas, or know folks who might? Thanks!

I tried it locally, but was not able to get build failure.

I get one unusual log line, but it does not seem to be fatal.
nm: ./libassistant.so: unknown type [0x13] section `.relr.dyn'

The warning from #6 is that we enabled smallpie( go/smallpie) for ChromeOS and this is support is not on Chromium yet.

It seems that it used the wrong linker.
It should use gold from  -B../../../../../../chromeos/assistant/libassistant/src/third_party/binutils/Linux_x64/Release/bin 

But it used the one under /user/bin

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/src-internal.git/+/f833265864b26a3443cfb91b2c1e03cf8845176e

commit f833265864b26a3443cfb91b2c1e03cf8845176e
Author: Xiaohui Chen <xiaohuic@google.com>
Date: Fri Oct 05 17:37:28 2018

what component can we assign to this?

what component can we assign to this?

+kbleicher +geohsu

Does this bug have an owner?  Assume we're beyond triaged?  This is a fairly serious blocker for the M70/71 PFQs.  Thanks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a39ca01e16443dc7aad07ba19c4544f86dbf47

commit 64a39ca01e16443dc7aad07ba19c4544f86dbf47
Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Date: Fri Oct 05 20:21:52 2018

Roll src-internal 4e9584b32dfe..89a5e559a7c9 (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e9584b32dfe..89a5e559a7c9


Created with:
  gclient setdep -r src-internal@89a5e559a7c9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:892125 
TBR=mmoss@chromium.org

Change-Id: I25a39107cdbc9bad3867f61d6ddf3bbbbe202f98
Reviewed-on: https://chromium-review.googlesource.com/c/1265044
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#597270}
[modify] https://crrev.com/64a39ca01e16443dc7aad07ba19c4544f86dbf47/DEPS

re#13 - xiaohuic patch in c#9 should have fixed this, and it looks like it just rolled onto the main chrome repo.

If we could start running the bots now to see that would be nice, the failures should come out pretty quickly if not.

Seems like the bots are still failing, they're still on 71.0.3571.0 which does not include the roll in c#14.

bots are not failing because of the issue on Sunday

[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.

This does not affect M70