New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 892116 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Oct 5
Cc:
blundell@chromium.org
█ jialiul@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[ChromeOS] Fix weird interaction between ArcSessionManagerBrowsertest and AdvancedProtectionStatusManager

Project Member Reported by ma...@igalia.com, Oct 4 
As mentioned in [1], in the context of  https://crbug.com/887264 , "there some weird interaction between arc_session_manager_browsertest and advanced_protection_status_manager in the linux-chromos-rel trybot test.  It's probably due to the way how arc_*_browsertest mock its testing profile and ProfileOAuth2TokenServiceFactory."

As suggested there, we're disabling advanced_protection_status_manager in ChromeOS during tests for now, so this ticket is to remember to fix the root issue.


[1] https://chromium-review.googlesource.com/c/chromium/src/+/1250968#message-49b6b418f342306240d138205a2e20816475d219
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/838777d5d885ae3ec431945fdb097d40b6a33ca9

commit 838777d5d885ae3ec431945fdb097d40b6a33ca9
Author: Jialiu Lin <jialiul@chromium.org>
Date: Fri Oct 05 23:16:19 2018

Seed AccountTrackerService and SigninManager properly in Arc* tests

During the migration to IdentityManager, we noticed that some Arc*
related tests setup are incomplete, such that they will potentially fail
after IdentityManager migration.

This CL adds more initial test setup to seed AccountTrackerService and
SigninManager properly. No behavior or logic change.

Bug: 883318,  892116 
Change-Id: I4db443d7bd0c7df396e1c188743b869d2b9c2e82
Reviewed-on: https://chromium-review.googlesource.com/c/1265079
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597361}
[modify] https://crrev.com/838777d5d885ae3ec431945fdb097d40b6a33ca9/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc
[modify] https://crrev.com/838777d5d885ae3ec431945fdb097d40b6a33ca9/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc

Comment 2 by jialiul@chromium.org, Oct 5

Status: Fixed (was: Untriaged)
►

Sign in to add a comment