New issue
Advanced search Search tips

Issue 892103 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Print preview overlay gets closed on pressing 'Cmd -' on Mac

Reported by vineetha...@etouch.net, Oct 4

Issue description

Chrome Version: 71.0.3569.0 (Official Build) fb87327b9e0a0a50c96e084943e5525c25f76fd1-refs/branch-heads/3569@{#1}(32/64-bit)
OS: Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6)

What steps will reproduce the problem?
1. Launch chrome, give print command (Ctrl + P) to open Print Preview overlay.
2. Press 'Cmd -' and observe.

Actual Result  : Print preview overlay gets closed on pressing 'Cmd -'.
Expected Result: Print preview overlay should not get closed on pressing 'Cmd -'.

This is a regression issue broken in ‘M-67’ and below is the 'per-revision' bisect information:
Good Build : 67.0.3394.0 (Revision : 549696)
Bad Build  : 67.0.3395.0 (Revision : 549859)

You are probably looking for a change made after 549701 (known good), but no later than 549702 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/81487d859688a8121fc415d258bfb845a0a07c8b..b7554e2a1d0a8108947a624e440819bc1a3fbade

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Note: 
1. Issue is specific to Mac OS
2. Issue is also reproducible on latest Canary #71.0.3570.0

Thank you!
 
ActualVideo.mov
1.2 MB View Download
ExpectedVideo.mov
2.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d3512c9f4c9745e85c078e0ac8b6237eb177277

commit 8d3512c9f4c9745e85c078e0ac8b6237eb177277
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Oct 05 15:07:12 2018

Print Preview Refresh: Fix mac key event handling

Should close dialog on Cmd+Period not Cmd+Minus

Bug:  892103 
Change-Id: Ia2795c3ccc796c9afa676d401502dc4c3efa6005
Reviewed-on: https://chromium-review.googlesource.com/c/1262433
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597123}
[modify] https://crrev.com/8d3512c9f4c9745e85c078e0ac8b6237eb177277/chrome/browser/resources/print_preview/new/app.js

Status: Started (was: Assigned)
This should be fixed by the change in comment 1. Please verify when it lands in Canary.
Canary works correctly.
Status: Fixed (was: Started)
Thanks for verifying.

Sign in to add a comment