New issue
Advanced search Search tips

Issue 892094 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 9
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary scroll bar is seen on 'Select a destination' overlay on 'Print Preview'

Reported by khushal....@etouch.net, Oct 4 
Chrome Version: 71.0.3570.0 (Official Build) Revision d749df9f798cd58c5c4a0866e4ca1bcb1edd494d-refs/branch-heads/3570@{#1} (64-bit)

OS: Mac (10.13.1)

Pre-condition: No printer should be added in Print Destinations (only 'Save as PDF' option should be present).

What steps will reproduce the problem?
1. Launch chrome and press 'Ctrl+P' to open 'Print Preview' page.
2. Now click on 'Change' button and Observe 'Select a destination' overlay.

Actual Result: Unnecessary scroll bar is seen on 'Select a destination' overlay on 'Print Preview'.

Expected Result: Scroll bar should be seen on 'Select a destination' overlay when necessary.

This is a Regression issue seen from 'M-71' and providing the bisect info below:
Good Build: 71.0.3569.0 (Revision: 596016)
Bad Build:  71.0.3570.0 (Revision: 596428)

(Unable to provide bisect using Per-revision script as "RuntimeError: We don't have enough builds to bisect" error message is thrown. Also, tried bisecting on other Mac machines and same error is thrown. Hence, providing suspect using Chromium bisect)

You are probably looking for a change made after 596307 (known good), but no later than 596337 (first known bad).

CHANGE-LOG URL:

https://chromium.googlesource.com/chromium/src/+log/931b6ae754be7eb495ecdbaf0a480c4368823894..819108fc62ef344832482d7e5cc5cdb175ed58c0

Suspecting: r596332 ??

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is not seen on Win (7, 8, 8.1, 10), Linux (14.04 LTS) & Mac (10.12.6, 10.13.6, 10.14.1).

Please refer the attached screen-cast.

Thank You..!!
Actual Video.mov
5.6 MB View Download
Expected Video.mov
5.9 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8b0d20b81e7a516c98f73b45a1beee55a41245

commit 8a8b0d20b81e7a516c98f73b45a1beee55a41245
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Oct 06 01:52:09 2018

Print Preview refresh: Make min heights shorter for destinations lists

Make the minimum height 2 destinations instead of 3. Adjust the max
height of the recent destinations list based on the number of recent
destinations.

Bug:  892094 
Change-Id: I90cd48f0bc810a0fc7915fd621e581c8af3fcd63
Reviewed-on: https://chromium-review.googlesource.com/c/1262411
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597395}
[modify] https://crrev.com/8a8b0d20b81e7a516c98f73b45a1beee55a41245/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/8a8b0d20b81e7a516c98f73b45a1beee55a41245/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/8a8b0d20b81e7a516c98f73b45a1beee55a41245/chrome/browser/resources/print_preview/new/destination_list.html
[modify] https://crrev.com/8a8b0d20b81e7a516c98f73b45a1beee55a41245/chrome/browser/resources/print_preview/new/destination_list.js

Comment 2 by rbpotter@chromium.org, Oct 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment