New issue
Advanced search Search tips

Issue 892093 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 9
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] 'Print' button appears to be blank for a moment after giving the print command.

Reported by dchau...@etouch.net, Oct 4 
Chrome Version: 71.0.3569.0 (Official Build) Revision	fb87327b9e0a0a50c96e084943e5525c25f76fd1-refs/branch-heads/3569@{#1} (32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) and Linux(14.04 LTs).

What steps will reproduce the problem?
1. Launch Chrome, give print command on any webpage and observe the 'Print' button.

Actual: 'Print' button appears to be blank for a moment.
Expected: 'Print' button should not appear blank.

This is a regression issue, broken in M-71 series, below is manual regression range:

Good build: 71.0.3551.0 (Revision: 590851)
Bad build: 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/974aa7b559b4361d7410479796becb0b933dc6a4..e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

Suspecting: https://chromium.googlesource.com/chromium/src/+/e73e92b7fbf4206ffdb20282ac73bcbed7cf910e

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast & screenshot for reference.

Thank you.
Print_button_Screenshot.png
11.5 KB View Download
Actual behavior.mp4
744 KB View Download
Expected behavior.mp4
828 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9795a6f783b37999ca3188c7c5ff681a37adaef

commit b9795a6f783b37999ca3188c7c5ff681a37adaef
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Oct 05 15:55:19 2018

Print Preview Refresh: Initialize print button text

Ensure the print button starts out with a default "Print" value instead
of waiting for the destination to load to display text.

Bug:  892093 
Change-Id: I1ca54476107a112ac4cccde463b8f1def1e6e501
Reviewed-on: https://chromium-review.googlesource.com/c/1262619
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597145}
[modify] https://crrev.com/b9795a6f783b37999ca3188c7c5ff681a37adaef/chrome/browser/resources/print_preview/new/header.html
[modify] https://crrev.com/b9795a6f783b37999ca3188c7c5ff681a37adaef/chrome/browser/resources/print_preview/new/header.js

Comment 2 by rbpotter@chromium.org, Oct 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment