Issue metadata
Sign in to add a comment
|
WebViewTest.Shim_testFindInMultipleWebViews is flaky |
||||||||||||||||||||||||
Issue descriptionFlaky test: WebViewTest.Shim_testFindInMultipleWebViews Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=40562ebb9dab1410 Test output log: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/72002 Culprit (88.0% confidence): https://chromium-review.googlesource.com/q/I0bf0b7fffcf9c6b6870b636954f130b655642a0c Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcyMDAyL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlWbWxsZDFSbGMzUXVVMmhwYlY5MFpYTjBSbWx1WkVsdVRYVnNkR2x3YkdWWFpXSldhV1YzY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebViewTest.Shim_testFindInMultipleWebViews&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyuAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKBAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcyMDAyL25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1YyVmlWbWxsZDFSbGMzUXVVMmhwYlY5MFpYTjBSbWx1WkVsdVRYVnNkR2x3YkdWWFpXSldhV1YzY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
,
Oct 4
Disabling CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1261700
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97ba6ddb3e711eff30910c3b5c63c6c07bfc806e commit 97ba6ddb3e711eff30910c3b5c63c6c07bfc806e Author: Martin Šrámek <msramek@chromium.org> Date: Thu Oct 04 15:33:41 2018 Disable WebViewTest.Shim_testFindInMultipleWebViews on Windows Due to flakiness. TBR=ekaramad@chromium.org Bug: 892085 Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06 Reviewed-on: https://chromium-review.googlesource.com/c/1261700 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596682} [modify] https://crrev.com/97ba6ddb3e711eff30910c3b5c63c6c07bfc806e/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Oct 4
Note that this is only for network_service_browser_tests. The strangest part here is that my change doesn't do any behavioral changes, it's all behind a flag. The only behavioral change is how inspector agents are stored.
,
Oct 4
,
Oct 4
Removing Sheriff-Chromium as the test is disabled.
,
Oct 4
,
Jan 3
re-enabling to see if it is flaky still
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bce878b00ade8b4488ccd5ba990e05c9450bd4af commit bce878b00ade8b4488ccd5ba990e05c9450bd4af Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Jan 03 21:33:56 2019 Revert "Disable WebViewTest.Shim_testFindInMultipleWebViews on Windows" This reverts commit 97ba6ddb3e711eff30910c3b5c63c6c07bfc806e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable WebViewTest.Shim_testFindInMultipleWebViews on Windows > > Due to flakiness. > > TBR=ekaramad@chromium.org > > Bug: 892085 > Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06 > Reviewed-on: https://chromium-review.googlesource.com/c/1261700 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596682} TBR=msramek@chromium.org,ekaramad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892085 Change-Id: I8b417d49cef605a3dd734886332ac70b1f53d8d7 Reviewed-on: https://chromium-review.googlesource.com/c/1394869 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#619763} [modify] https://crrev.com/bce878b00ade8b4488ccd5ba990e05c9450bd4af/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
Jan 3
Let's close this if no reverts happen in two weeks.
,
Jan 17
(5 days ago)
The NextAction date has arrived: 2019-01-17
,
Jan 17
(5 days ago)
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by msramek@chromium.org
, Oct 4Status: Assigned (was: Untriaged)