New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 892076 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-15
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Task


Sign in to add a comment

[tracking bug::UserConsent] Post launch cleanup

Project Member Reported by vitaliii@chromium.org, Oct 4

Issue description

Currently we have 2 implementations to submit user consents (through user events and through a separate datatype). We want to fully migrate to the separate datatype. I've discussed with markusheintz@ and we are not aware of any issue with the new datatype in M69. Thus, I can start cleaning up the old implementation.

I will wait for M71 BP to pass.
 
Components: Services>Sync
Summary: [tracking bug::UserConsent] Post launch cleanup (was: [UserConsent] Post launch cleanup)
The NextAction date has arrived: 2018-10-15
Labels: sync-fixit-2018q4
Owner: vitaliii@chromium.org
Blockedon: 905636
Blockedon: 905639
Owner: ----
Status: Available (was: Assigned)
I had a look, created more bugs and close obsolete ones.

If I were doing this, I would do the following:

0) Remove TODO about garbage collection from both Consent and UserEvents code ( issue 851439 ).
1) Delete the enabled-dy-default feature gating the new datatype ( issue 905636 ).
2) Remove consents logic from user events code. This will involve factories as well, I am not sure whether this could be broken down into multiple CLs. It may be possible to deprecate some fields in protos as well. ( issue 905639 )
3) Rewrite and reenable user event web browser test. Also add a similar test for UserConsents datatype. (issue 843847)
4) Improve mess with dependencies (issue 850428).


If you need any help, please ask! Thank you!
Labels: -OS-Fuchsia
Owner: treib@chromium.org
Status: Started (was: Available)
I'll give this a shot.
Status: Fixed (was: Started)
I think we can close the tracking bug. There's still bug 843847 (originally about a flaky test which has since been removed, now repurposed to possibly adding some additional tests), and bug 850428 about a dependency cycle which is being actively addressed.

Sign in to add a comment