No gap is seen between 'Done' and 'Cancel' button on 'Add shortcut' overlay.
Reported by
aiman.an...@etouch.net,
Oct 4
|
||||||
Issue descriptionChrome Version: 71.0.3569.0 Revision fb87327b9e0a0a50c96e084943e5525c25f76fd1-refs/branch-heads/3569@{#1}(32/64 bit) OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS. Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags and relaunch the browser. What steps will reproduce the problem? 1. Launch Chrome, navigate to 'chrome://settings/fonts'. 2. Navigate to chrome://settings/fonts and change Minimum font size to 'Huge'. 3. Navigate to NTP, click on 'Add Shortcut' link to open the overlay. 4. Observe Cancel and Done button. Actual Result: No gap is seen between 'Done' and 'Cancel' button on 'Add shortcut' overlay. Expected Result: Proper gap should be seen between 'Done' and 'Cancel' button on 'Add shortcut' overlay. This is Non-Regression issue seen from ‘M-70’ from build #70.0.3504.0, as 'Add shortcut' option was introduced on NTP. Kindly review the attached screen-cast for reference. Thank you..!!
,
Oct 4
,
Oct 4
,
Oct 4
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aae05875997fd83069b7eb5c7d12b7932bb56187 commit aae05875997fd83069b7eb5c7d12b7932bb56187 Author: Kristi Park <kristipark@chromium.org> Date: Thu Oct 04 20:51:31 2018 [NTP] Allow custom link dialog to resize when font is set to large Change width to min-width in order to allow the dialog to resize when font size changes. Screenshot: https://screenshot.googleplex.com/YzVigoNCRC8.png Bug: 892066 Change-Id: I1bb89eb40a42f6dc045957b1d807bbad04b92251 Reviewed-on: https://chromium-review.googlesource.com/c/1262403 Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#596842} [modify] https://crrev.com/aae05875997fd83069b7eb5c7d12b7932bb56187/chrome/browser/resources/local_ntp/custom_links_edit.css
,
Oct 4
,
Oct 5
Hi, Retested the above issue on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14.1) & Linux(14.04 LTS) OS using latest Canary build #71.0.3571.0 and issue is fixed. Now, gap is seen between Cancel and Done button. Kindly refer the attached screen-cast. Thank You! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ramyan@chromium.org
, Oct 4Owner: kristip...@chromium.org