New issue
Advanced search Search tips

Issue 892024 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Text caret disappears from 'Custom' text field after clicking on 'Custom' radio button twice.

Reported by avsha...@etouch.net, Oct 4

Issue description

Chrome Version : 71.0.3569.0 (Official Build) fb87327b9e0a0a50c96e084943e5525c25f76fd1-refs/branch-heads/3569@{#1} 32/64 bit
OS : Windows(7, 8, 8.1 ,10), Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open NTP and open print preview using 'Ctrl + P' key shortcut.
2. In 'Pages' section, click on 'Custom' radio button twice and observe the text field.

Actual Result : Text caret disappears from 'Custom' text field after clicking on 'Custom' radio button twice.

Expected Result : Text caret should stay in text field even if user click on 'Custom' radio button multiple times.

This is a regression issue broken in ‘M-71’ and below is the 'Chromium bisect' information:
Good Build : 71.0.3564.0 (Revision : 594950)
Bad Build : 71.0.3565.0 (Revision : 595251)

Chromium bisect URL:
https://chromium.googlesource.com/chromium/src/+log/44a2e6f192177bd280e7aaec12bfdd20f2cf6641..9b7e8547498ccb8cf22490e5b2387c142216cfc9

Suspect: r594974

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Able to reproduce this issue in latest Canary build #71.0.3570.0
2. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message.
3. Tried on other machines but still getting the same error again.
4. Hence provided suspect through 'Chromium bisect'

Thank you..!
 
Actual_print_preview.mp4
551 KB View Download
Expected_Print_Preview.mp4
313 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5

commit dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Oct 05 15:08:45 2018

Print Preview Refresh: Fix some pages polish bugs

Ensure the rest of the UI gets re-enabled if an error is cleared
Always focus the custom pages input if the custom radio button is
clicked

Bug:  892024 ,  892023 
Change-Id: Iec93a4ca313dff63fc143aa90c916b3111f37a9a
Reviewed-on: https://chromium-review.googlesource.com/c/1262412
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597125}
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/test/data/webui/print_preview/pages_settings_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment