New issue
Advanced search Search tips

Issue 892023 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Oct 8
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : [Print Preview]Unnecessary 'Layout' and 'Color' drop down lists appears disabled.

Reported by rp...@etouch.net, Oct 4 
Chrome version: 71.0.3570.0 (Official Build)Revision d749df9f798cd58c5c4a0866e4ca1bcb1edd494d-refs/branch-heads/3570@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview
2. Now click on Pages text field and press 'Space bar' key so that error message is displayed.
3. Now press 'backspace' key and observe 'Layout' and 'Color' drop down lists

Actual Result: Unnecessary 'Layout' and 'Color' drop down lists appears disabled
Expected Result: 'Layout' and 'Color' drop down lists shouldn't be in disabled state

This is regression issue broken in ‘M-71’ and will soon update other info:
Good build: 71.0.3569.0 (Revision: 596016)
Bad build : 71.0.3570.0 (Revision: 596428)
Actual_video.mp4
268 KB View Download
Expected_video.mp4
222 KB View Download

Comment 1 by rp...@etouch.net, Oct 4

Labels: hasbisect OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 596089 (known good), but no later than 596096 (first known bad).

Chromium bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/ba1269835a6aa4b496d6979bc27012ac4609c95b..444e40d835950f16bca8cd39d0303b012bc6ba52?pretty=fuller&n=50

Suspect : r596093 ?

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message.
2. Tried on other machines but still getting the same error again , Hence provided suspect through 'Chromium bisect'
3. In this issue 'More settings' and 'Print using system dialog' buttons also appear disabled.

Comment 2 by rbasuvula@chromium.org, Oct 4

Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5

commit dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Oct 05 15:08:45 2018

Print Preview Refresh: Fix some pages polish bugs

Ensure the rest of the UI gets re-enabled if an error is cleared
Always focus the custom pages input if the custom radio button is
clicked

Bug:  892024 ,  892023 
Change-Id: Iec93a4ca313dff63fc143aa90c916b3111f37a9a
Reviewed-on: https://chromium-review.googlesource.com/c/1262412
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597125}
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/dfc1fc4853bf3375d86f185bfb52a997e7fe8ef5/chrome/test/data/webui/print_preview/pages_settings_test.js

Comment 4 by rp...@etouch.net, Oct 8

Labels: TE-Verified-M71 TE-Verified-71.0.3573.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14.1) using latest Canary build : 71.0.3573.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mp4
335 KB View Download

Comment 5 by rbpotter@chromium.org, Oct 8

Status: Verified (was: Assigned)
►

Sign in to add a comment