PortalBrowserTest.ActivatePortalInShell is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20PortalBrowserTest.ActivatePortalInShell&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc04085e316700aa2260e864a739a40d3532a61f commit bc04085e316700aa2260e864a739a40d3532a61f Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Oct 04 11:47:13 2018 Revert "Portals: Support activating a portal." This reverts commit 831290e17ad0fccc4af70516218bf35833d88ac7. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 596428 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vODMxMjkwZTE3YWQwZmNjYzRhZjcwNTE2MjE4YmYzNTgzM2Q4OGFjNww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14218 Sample Failed Step: viz_content_browsertests Sample Flaky Test: PortalBrowserTest.ActivatePortalInShell Original change's description: > Portals: Support activating a portal. > > When a portal is activated, the portal contents replace the tab contents. > > Bug: 865565 > Change-Id: Id666e94b0c98294dbc2eb1ce942101a2f158ebf3 > Reviewed-on: https://chromium-review.googlesource.com/c/1188884 > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596428} Change-Id: I8700b1340612578081c2b3ccd12a57ff48f0fd84 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865565, 892004 Reviewed-on: https://chromium-review.googlesource.com/c/1261595 Cr-Commit-Position: refs/heads/master@{#596601} [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_android.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_android.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/android/tab_web_contents_delegate_android.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/dom_distiller/tab_utils.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/prerender/prerender_manager.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/sessions/session_restore_android.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/browser.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/browser.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/tab_contents/core_tab_helper_delegate.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/chrome/browser/ui/tab_contents/core_tab_helper_delegate.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/browser/portal/portal_browsertest.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/public/browser/web_contents_delegate.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/public/browser/web_contents_delegate.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/shell/browser/shell.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/content/shell/browser/shell.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/public/mojom/portal/portal.mojom [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.h [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/third_party/blink/renderer/core/html/portal/html_portal_element.idl [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/ui/views/controls/webview/webview.cc [modify] https://crrev.com/bc04085e316700aa2260e864a739a40d3532a61f/ui/views/controls/webview/webview.h
The CL that added this test was reverted. Removing from Sheriff-Chromium.
PortalBrowserTest.ActivatePortalInShell is flaky. Findit has detected 13 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20PortalBrowserTest.ActivatePortalInShell&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Test is still flaky; I'll see if the revert applies cleanly.
Hmm the revert doesn't apply cleanly :( I'll disable the test.
Disable is at: https://crrev.com/c/1267835
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6773c81124d4bb32fbe938babde9edfd35dda6b5 commit 6773c81124d4bb32fbe938babde9edfd35dda6b5 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Oct 08 03:19:04 2018 sheriff: Disable flaky portal test TBR=boliu@chromium.org Bug: 892004 Change-Id: I5d65e66001e164b5b079927a2c62bb1fa3cc8d29 Reviewed-on: https://chromium-review.googlesource.com/c/1267835 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#597478} [modify] https://crrev.com/6773c81124d4bb32fbe938babde9edfd35dda6b5/content/browser/portal/portal_browsertest.cc
PortalBrowserTest.ActivatePortalInShell is flaky. Findit has detected 3 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20PortalBrowserTest.ActivatePortalInShell&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb3J0YWxCcm93c2VyVGVzdC5BY3RpdmF0ZVBvcnRhbEluU2hlbGwM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
#9 did not actually disable the test. https://chromium-review.googlesource.com/c/chromium/src/+/1268516 will disable it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c44412d395553d27801bbef62b3c160ac006710 commit 7c44412d395553d27801bbef62b3c160ac006710 Author: Joshua Pawlicki <waffles@chromium.org> Date: Mon Oct 08 15:41:00 2018 Disable ActivatePortalInShell test. Previous sheriff attempted disable but forgot the MAYBE_. TBR=ortuno@chromium.org Bug: 892004 Change-Id: I98ebef818d3e270f277f9f61be0090af9a0a195a Reviewed-on: https://chromium-review.googlesource.com/c/1268516 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597566} [modify] https://crrev.com/7c44412d395553d27801bbef62b3c160ac006710/content/browser/portal/portal_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74c10cd363bb25676d5434ec9bbc40b89dcf27a0 commit 74c10cd363bb25676d5434ec9bbc40b89dcf27a0 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Fri Nov 02 19:24:57 2018 Portals: Re-enable PortalBrowserTest.ActivatePortalInShell on Android. This CL fixes the test flakyness and enables the test on Android. Bug: 892004 Change-Id: Ibc08897c300ce9704cebf861249b8c7f719cf474 Reviewed-on: https://chromium-review.googlesource.com/c/1313735 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605012} [modify] https://crrev.com/74c10cd363bb25676d5434ec9bbc40b89dcf27a0/content/browser/android/selection/selection_popup_controller.cc [modify] https://crrev.com/74c10cd363bb25676d5434ec9bbc40b89dcf27a0/content/browser/android/selection/selection_popup_controller.h [modify] https://crrev.com/74c10cd363bb25676d5434ec9bbc40b89dcf27a0/content/browser/portal/portal_browsertest.cc [modify] https://crrev.com/74c10cd363bb25676d5434ec9bbc40b89dcf27a0/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java
Comment 1 by bugdroid1@chromium.org
, Oct 4