New issue
Advanced search Search tips

Issue 891997 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 870173



Sign in to add a comment

Some SharedWorkerHostTest fails if ServiceWorkerServicification is enabled

Project Member Reported by toyoshim@chromium.org, Oct 4

Issue description

SharedWorkerHostTest.Normal
SharedWorkerHostTest.OnContextClosed
SharedWorkerHostTest.TerminateAfterStarting

repro step:
./out/Release/content_unittests --gtest_filter=SharedWorkerHostTest.\* --enable-features=ServiceWorkerServicification
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58506c589a27b84bc81efd2aaeaca8d7fbbbb469

commit 58506c589a27b84bc81efd2aaeaca8d7fbbbb469
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Oct 04 04:19:22 2018

S13nServiceWorker: Fix some SharedWorkerHostTests

Pass a mock URLLoaderFactoryPtrInfo to URLLoaderFactoryBundleInfo
as SharedWorkerHost requires the default loader factory when
S13nServiceWorker is on.

Bug:  891997 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id656e2fe26fd44a25b6b367bb401553201d4b17a
Reviewed-on: https://chromium-review.googlesource.com/c/1260783
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596499}
[modify] https://crrev.com/58506c589a27b84bc81efd2aaeaca8d7fbbbb469/content/browser/shared_worker/shared_worker_host_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment