New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Add COMMIT-QUEUE.ini for biod

Project Member Reported by pmalani@chromium.org, Oct 4

Issue description

biod CLs Pre CQ iterations run on unrelated/unaffected h/w like kevin (see an example here: https://chromeos-cl-viewer-ui.googleplex.com/cl_status/chromium-review.googlesource.com/1259583/1)

This makes Pre CQ times unnecessarily long (and puts an unnecessary strain on Pre CQ builders)

We should add a COMMIT-QUEUE.ini file to biod to list out those hardware on which we want  biod CLs to run for Pre CQ. We should only keep a handful (i.e 1 per arch) of boards which don't support biod, just in case, and then only add boards when the H/W becomes available.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/24b81a75213985caa8b06b50ba90fe4c6fba06dc

commit 24b81a75213985caa8b06b50ba90fe4c6fba06dc
Author: Prashant Malani <pmalani@chromium.org>
Date: Wed Oct 10 04:14:38 2018

biod: Add COMMIT-QUEUE.ini

Since biod only runs on limited devices, limit the number of pre-cq
configurations to a handful of representative ones.

BUG= chromium:891981 
TEST=None

Change-Id: I38d774adffe355738be121c173ad1ff8d522fbb8
Reviewed-on: https://chromium-review.googlesource.com/1262235
Commit-Ready: Prashant Malani <pmalani@google.com>
Commit-Ready: Prashant Malani <pmalani@chromium.org>
Tested-by: Prashant Malani <pmalani@google.com>
Tested-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>

[add] https://crrev.com/24b81a75213985caa8b06b50ba90fe4c6fba06dc/biod/COMMIT-QUEUE.ini

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4559bd06c12dca8279cbfcd7c40e5366e703a909

commit 4559bd06c12dca8279cbfcd7c40e5366e703a909
Author: Prashant Malani <pmalani@chromium.org>
Date: Wed Oct 10 04:14:48 2018

Add common COMMIT-QUEUE.ini to allow subdir union

Different subdirs may have their custom COMMIT-QUEUE.ini; in CLs that
straddle multiple subdirs, we would like the various configs to be
unioned, instead of being ignored. This file enables the unioning.

BUG= chromium:891981 
TEST=None

Change-Id: Icac2b1582bbe824a82561276d3f3605eba259cd3
Reviewed-on: https://chromium-review.googlesource.com/1266215
Commit-Ready: Prashant Malani <pmalani@google.com>
Commit-Ready: Prashant Malani <pmalani@chromium.org>
Tested-by: Prashant Malani <pmalani@google.com>
Tested-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>

[add] https://crrev.com/4559bd06c12dca8279cbfcd7c40e5366e703a909/COMMIT-QUEUE.ini

Status: Fixed (was: Unconfirmed)
Labels: -Restrict-View-Google -Type-Bug Type-Feature
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8

Labels: merge-merged-factory-nami-10715.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c9f09ba089748e6f57047d43cb64b04fa3921217

commit c9f09ba089748e6f57047d43cb64b04fa3921217
Author: Prashant Malani <pmalani@chromium.org>
Date: Sat Dec 08 02:03:55 2018

biod: Add COMMIT-QUEUE.ini

Since biod only runs on limited devices, limit the number of pre-cq
configurations to a handful of representative ones.

BUG= chromium:891981 
TEST=None

Change-Id: I38d774adffe355738be121c173ad1ff8d522fbb8
Reviewed-on: https://chromium-review.googlesource.com/1262235
Commit-Ready: Prashant Malani <pmalani@google.com>
Commit-Ready: Prashant Malani <pmalani@chromium.org>
Tested-by: Prashant Malani <pmalani@google.com>
Tested-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
(cherry picked from commit 24b81a75213985caa8b06b50ba90fe4c6fba06dc)
Reviewed-on: https://chromium-review.googlesource.com/c/1362343
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>

[add] https://crrev.com/c9f09ba089748e6f57047d43cb64b04fa3921217/biod/COMMIT-QUEUE.ini

Sign in to add a comment