Issue metadata
Sign in to add a comment
|
CrSettingsLanguagesPageTest.AddLanguagesDialog is flaky |
||||||||||||||||||||
Issue descriptionCrSettingsLanguagesPageTest.AddLanguagesDialog is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENyU2V0dGluZ3NMYW5ndWFnZXNQYWdlVGVzdC5BZGRMYW5ndWFnZXNEaWFsb2cM. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20CrSettingsLanguagesPageTest.AddLanguagesDialog&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQENyU2V0dGluZ3NMYW5ndWFnZXNQYWdlVGVzdC5BZGRMYW5ndWFnZXNEaWFsb2cM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Oct 4
,
Oct 4
The test was enabled by https://chromium-review.googlesource.com/c/1259465 (Cr-Commit-Position: refs/heads/master@{#596376}) The first failure was https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/154307 ("refs/heads/master@{#596376}")
,
Oct 4
Disabled and assigned -> removing from Sheriff's queue.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ac9efde13ee571387899d6d3fcf12e3d543e963 commit 3ac9efde13ee571387899d6d3fcf12e3d543e963 Author: rbpotter <rbpotter@chromium.org> Date: Fri Oct 05 15:07:40 2018 Settings UI: Fix and re-enable AddLanguagesDialog test This test was flaky when run with Polymer 2, specifically failing to find > 0 non-hidden list items in the dialog. This appears to have been due to a timing issue with the setTimeout() call in the test setup causing the test to fail inconsistently. This failure could not be reproduced locally with the original test. However, exchanging setTimeout() for waiting for the dialog to open resulted in the same failure occurring consistently with Polymer 2 (but not with Polymer 1). The failure was then fixed by adding Polymer.dom.flush() to ensure the dialog had finished filtering languages before querying for the items. Bug: 875454 , 891955 Change-Id: I05c2b60ad0d12619e388a5469a0c1a0418e35a8c Reviewed-on: https://chromium-review.googlesource.com/c/1262973 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597124} [modify] https://crrev.com/3ac9efde13ee571387899d6d3fcf12e3d543e963/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/3ac9efde13ee571387899d6d3fcf12e3d543e963/chrome/test/data/webui/settings/languages_page_tests.js
,
Oct 9
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 4