This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/0dae561acbf416b7e63aab63c8c3ec6c831c9756

commit 0dae561acbf416b7e63aab63c8c3ec6c831c9756
Author: Micah Morton <mortonm@chromium.org>
Date: Thu Oct 04 16:27:28 2018

shill: modify init script for sandboxing kill switch

NOTE: this is a cherry pick of CL:1251883 to M70, with the exception
that we don't hard-code shill.sh to always run shill as root. We don't
need to do that, since the ShillSandboxing flag is default disabled
in M70 now.

Modify these scripts to allow for shill to be run as root by default
and only run in a sandbox when the ShillSandboxing flag is enabled in
Chrome.

BUG= chromium:891949 ,chromium:649417
TEST=scp the files over to M70 beta image and reboot while
enabling/disabling flag in /etc/chrome-dev.conf

Change-Id: I106408a80bc7f02d50d19693b918380102ed3fe2

[modify] https://crrev.com/0dae561acbf416b7e63aab63c8c3ec6c831c9756/init/shill-sandboxing-kill-switch.conf
[modify] https://crrev.com/0dae561acbf416b7e63aab63c8c3ec6c831c9756/init/shill.sh

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Long past where this matters...but I think this was done.