Merge shill sandboxing chrome flag back to M70 |
||||||||
Issue descriptionNeed to merge https://chromium-review.googlesource.com/c/chromium/src/+/1246830 back to M70 so we have a manual flag for disabling shill sandboxing in case network connectivity is lost.
,
Oct 3
,
Oct 3
,
Oct 3
,
Oct 3
Do we need approval from a Chrome TPM for M70 here? All the Chrome changes (besides the XML file) are behind '#if defined(OS_CHROMEOS)' ifdefs.
,
Oct 4
Relevant CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1254747 This is ChromeOS-specific browser code but giving a heads up to abdulsyed@. Not sure the exact rules on whether this merge needs approval from Chrome TPM
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd27dbcdec5e42a481cafd66e394c1af07affdf commit bdd27dbcdec5e42a481cafd66e394c1af07affdf Author: Micah Morton <mortonm@chromium.org> Date: Thu Oct 04 20:43:50 2018 Add flag so shill sandboxing can be force enabled/disabled. This flag allows users to work around a shill-related breakage due to sandboxing, by forcing the feature disabled. It also allows testers to toggle the feature during testing without needing to modify /etc/chrome-dev.conf. Having this flag in the chrome://flags will allow a user to manually enable/disable shill sandboxing without needing a VariationsService update, which might be infeasible if network connectivity is lost. BUG= chromium:891939 ,chromium:649417 Change-Id: I7d355d3291ef5fe9829c032b82453ebaf0855f98 Reviewed-on: https://chromium-review.googlesource.com/c/1254747 Reviewed-by: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#864} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/about_flags.cc [modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/flag_descriptions.h [modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/tools/metrics/histograms/enums.xml
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd27dbcdec5e42a481cafd66e394c1af07affdf Commit: bdd27dbcdec5e42a481cafd66e394c1af07affdf Author: mortonm@chromium.org Commiter: mnissler@chromium.org Date: 2018-10-04 20:43:50 +0000 UTC Add flag so shill sandboxing can be force enabled/disabled. This flag allows users to work around a shill-related breakage due to sandboxing, by forcing the feature disabled. It also allows testers to toggle the feature during testing without needing to modify /etc/chrome-dev.conf. Having this flag in the chrome://flags will allow a user to manually enable/disable shill sandboxing without needing a VariationsService update, which might be infeasible if network connectivity is lost. BUG= chromium:891939 ,chromium:649417 Change-Id: I7d355d3291ef5fe9829c032b82453ebaf0855f98 Reviewed-on: https://chromium-review.googlesource.com/c/1254747 Reviewed-by: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#864} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Nov 8
I believe this is Fixed? And the ship has sailed anyway. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mortonm@chromium.org
, Oct 3