New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891939 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 649417



Sign in to add a comment

Merge shill sandboxing chrome flag back to M70

Project Member Reported by mortonm@chromium.org, Oct 3

Issue description

Need to merge https://chromium-review.googlesource.com/c/chromium/src/+/1246830 back to M70 so we have a manual flag for disabling shill sandboxing in case network connectivity is lost.
 
Blocking: 649417
Labels: -Merge-Request-70 Merge-Approved-70
Cc: mnissler@chromium.org
Do we need approval from a Chrome TPM for M70 here? All the Chrome changes (besides the XML file) are behind '#if defined(OS_CHROMEOS)' ifdefs.
Cc: abdulsyed@chromium.org
Relevant CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1254747

This is ChromeOS-specific browser code but giving a heads up to abdulsyed@. Not sure the exact rules on whether this merge needs approval from Chrome TPM
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 4

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdd27dbcdec5e42a481cafd66e394c1af07affdf

commit bdd27dbcdec5e42a481cafd66e394c1af07affdf
Author: Micah Morton <mortonm@chromium.org>
Date: Thu Oct 04 20:43:50 2018

Add flag so shill sandboxing can be force enabled/disabled.

This flag allows users to work around a shill-related breakage due to
sandboxing, by forcing the feature disabled. It also allows testers to
toggle the feature during testing without needing to modify
/etc/chrome-dev.conf. Having this flag in the chrome://flags will allow
a user to manually enable/disable shill sandboxing without needing a
VariationsService update, which might be infeasible if network
connectivity is lost.

BUG= chromium:891939 ,chromium:649417

Change-Id: I7d355d3291ef5fe9829c032b82453ebaf0855f98
Reviewed-on: https://chromium-review.googlesource.com/c/1254747
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#864}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/about_flags.cc
[modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bdd27dbcdec5e42a481cafd66e394c1af07affdf/tools/metrics/histograms/enums.xml

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/bdd27dbcdec5e42a481cafd66e394c1af07affdf

Commit: bdd27dbcdec5e42a481cafd66e394c1af07affdf
Author: mortonm@chromium.org
Commiter: mnissler@chromium.org
Date: 2018-10-04 20:43:50 +0000 UTC

Add flag so shill sandboxing can be force enabled/disabled.

This flag allows users to work around a shill-related breakage due to
sandboxing, by forcing the feature disabled. It also allows testers to
toggle the feature during testing without needing to modify
/etc/chrome-dev.conf. Having this flag in the chrome://flags will allow
a user to manually enable/disable shill sandboxing without needing a
VariationsService update, which might be infeasible if network
connectivity is lost.

BUG= chromium:891939 ,chromium:649417

Change-Id: I7d355d3291ef5fe9829c032b82453ebaf0855f98
Reviewed-on: https://chromium-review.googlesource.com/c/1254747
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#864}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Untriaged)
I believe this is Fixed? And the ship has sailed anyway.

Sign in to add a comment