This property is not needed anymore. Applying the patch on bot_update instead of gclient has been the default for quite a while.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc43e7fe88a1808e1d17f204844416a57a17137e commit bc43e7fe88a1808e1d17f204844416a57a17137e Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed Oct 03 22:55:24 2018 cr-buildbucket.cfg: Don't set apply_patch_on_gclient property. It is now true by default, so there is no need to set it. Bug: 891917 Change-Id: Id9b9490daee59ef6f864217ea595e96f0535598b Reviewed-on: https://chromium-review.googlesource.com/c/1260016 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#596410} [modify] https://crrev.com/bc43e7fe88a1808e1d17f204844416a57a17137e/infra/config/global/cr-buildbucket.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0c3bd49069d44dd6c217f3db103d27bfc1272424 commit 0c3bd49069d44dd6c217f3db103d27bfc1272424 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Fri Oct 05 17:05:25 2018 bot_update: Don't use apply_patch_on_gclient. It has been True by default for a while, and there is no need to override it. Bug: 891917 Change-Id: I2598a2230b0ea38a647a533757331c541b871971 Reviewed-on: https://chromium-review.googlesource.com/c/1260057 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/tests/bot_update_coverage_test.py [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/recipe_modules/bot_update/examples/full.py [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/recipe_modules/bot_update/test_api.py [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/README.recipes.md [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/recipe_modules/bot_update/api.py [modify] https://crrev.com/0c3bd49069d44dd6c217f3db103d27bfc1272424/recipes/recipe_modules/bot_update/resources/bot_update.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f1f2374ef05933e0d0f8aa6cf7871a5fbb9d47 commit 05f1f2374ef05933e0d0f8aa6cf7871a5fbb9d47 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Oct 05 18:50:54 2018 Roll src/third_party/depot_tools 2fb631023730..0c3bd49069d4 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2fb631023730..0c3bd49069d4 git log 2fb631023730..0c3bd49069d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-05 ehmaldonado@chromium.org bot_update: Don't use apply_patch_on_gclient. Created with: gclient setdep -r src/third_party/depot_tools@0c3bd49069d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891917 TBR=agable@chromium.org Change-Id: I5d9d64b7c5d3f22b4958d8e4629f54246d1d7799 Reviewed-on: https://chromium-review.googlesource.com/c/1265061 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597215} [modify] https://crrev.com/05f1f2374ef05933e0d0f8aa6cf7871a5fbb9d47/DEPS
Comment 1 by bugdroid1@chromium.org
, Oct 3