crash-reporter unit tests leave junk behind in source tree |
|||
Issue descriptionRunning 'FEATURES=test emerge-kevin crash-reporter' on ToT results in a test directory being left behind in the source tree: $ ls ~/trunk/src/platform2/crash-reporter/test/container/ auxv cmdline environ maps status Looks like this has something to do with arc_collector, but I didn't look closer. Anyway, tests should make sure they put their junk in the portage working directory and not in the source tree.
,
Oct 4
Here's a simple fix: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1260227
,
Oct 4
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d206a9c9e7996869299a5b05e96630eee845148e commit d206a9c9e7996869299a5b05e96630eee845148e Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 05 18:37:42 2018 crash: generate test files in temporary directory This CL fixes the UserCollectorTest.CopyOffProcFilesBadPid and UserCollectorTest.CopyOffProcFilesOK test case to generate test files in the temporary directory created for the test instead of the current working directory. BUG= chromium:891913 TEST=Run unit tests and verify that no test file is generated in the source tree. Change-Id: Id6f7be0bfb45bce7a96a37599e056f8a90ac35a6 Reviewed-on: https://chromium-review.googlesource.com/1260227 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d206a9c9e7996869299a5b05e96630eee845148e/crash-reporter/user_collector_test.cc
,
Oct 5
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vapier@chromium.org
, Oct 3Labels: OS-Chrome
Status: Available (was: Untriaged)