New issue
Advanced search Search tips

Issue 891912 link

Starred by 1 user
Status: Fixed
Owner:
jsaul@google.com
Closed: Oct 8
Cc:
siyua@google.com
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Clean up AutofillUpstreamUpdatePromptExplanation

Project Member Reported by jsaul@google.com, Oct 3 
This one is tricky to clean up due to the Chrome/Payments communication. 
 Google Payments only shows the shortened, updated ToS if Chrome relays that it showed the longer, updated card upload prompt explanation.  This feature launched in M67 and M68.  Here's the cleanup plan:

1) Payments-side, determine Chrome version from the calling user agent string.  If M69+, *always* show the shortened ToS message.

2) Chrome-side, clean up experiment code.

As a result: Pre-M69 Chrome clients with the flag off will still be respected by Payments and show the longer legal message, while Payments will automatically assume the same logic as experiment-on for all Chrome clients M69+, allowing Chrome clients to stop sending experiment status.

Comment 1 by siyua@chromium.org, Oct 3 

Thanks for doing the clean up!
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88206a41290cef880e94f2f04846820b6d238eeb

commit 88206a41290cef880e94f2f04846820b6d238eeb
Author: Jared Saul <jsaul@google.com>
Date: Fri Oct 05 22:27:45 2018

[Autofill] Always enable updated prompt explanation for upload

Please see the bug for the detailed cleanup plan.

Bug:  891912 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifdb7cb4718917cdbf4f3e5137fe47a3c98c83997
Reviewed-on: https://chromium-review.googlesource.com/c/1260011
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597346}
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/chrome/browser/about_flags.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/components/autofill_strings.grdp
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/88206a41290cef880e94f2f04846820b6d238eeb/tools/metrics/histograms/enums.xml

Comment 3 by jsaul@google.com, Oct 8

Status: Fixed (was: Started)
►

Sign in to add a comment