New issue
Advanced search Search tips

Issue 891903 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::NodeRectInRootFrame

Project Member Reported by ClusterFuzz, Oct 3

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5446209047887872

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::NodeRectInRootFrame
  blink::SearchOrigin
  blink::FocusController::AdvanceFocusDirectionally
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=589501:589503

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5446209047887872

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 3

Components: Blink
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 3

Labels: Test-Predator-Auto-Owner
Owner: hu...@vewd.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/d6a58cc148802a2f3895d8a5a1cd2e6270f176cc (Snav: Define search origin as the first visible focus-container).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Oct 4

ClusterFuzz has detected this issue as fixed in range 596507:596508.

Detailed report: https://clusterfuzz.com/testcase?key=5446209047887872

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::NodeRectInRootFrame
  blink::SearchOrigin
  blink::FocusController::AdvanceFocusDirectionally
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=589501:589503
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=596507:596508

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5446209047887872

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Oct 4

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5446209047887872 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Cc: f...@opera.com
Status: Started (was: Verified)
I cannot reproduce it on today's master but I do reproduce it on yesterday's... Here's the needed fix for NodeRectInRootFrame:

+   if (!node->GetLayoutObject())
+    return LayoutRect();  // Clusterfuzz  Issue 891903 .

Even though it does no longer reproduce, I guess it makes sense to add this check?

Generally speaking, I guess Blink (here spatnav) can never assume that a Node has a LayoutObject, right?
Components: -Blink Blink>HTML>Focus



Status: Fixed (was: Started)
I reran Clusterfuzz's test case. I can confirm that this was fixed by our code change: 

https://chromium.googlesource.com/chromium/src/+log/581a728b2665c85e466408c2d53371abcb7f763e..4835e88efcb0d89732a26732b09729c496917efd?pretty=fuller&n=10000

Sign in to add a comment