New issue
Advanced search Search tips

Issue 891899 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

migrate update engine and its dependencies to gn

Project Member Reported by ahass...@chromium.org, Oct 3

Issue description

Just do what the title says:
- update_engine
- puffin
- bsdiff

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/9c9158805f159ac9a8eefa3880f75911e3757112

commit 9c9158805f159ac9a8eefa3880f75911e3757112
Author: Amin Hassani <ahassani@chromium.org>
Date: Wed Oct 24 23:45:05 2018

update_engine: Use static libraries of bsdiff and bspatch

BUG=chromium:891899
TEST=sudo FEATURES=test emerge bsdiff puffin update_engine
CQ-DEPEND=CL:1295293

Change-Id: I7eb5afc188d9527f342ab952d2c6d63f4c760bef
Reviewed-on: https://chromium-review.googlesource.com/1291835
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/9c9158805f159ac9a8eefa3880f75911e3757112/update_engine.gyp

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/091dcebfd92cc13819e859bc30b670896a02fffb

commit 091dcebfd92cc13819e859bc30b670896a02fffb
Author: Amin Hassani <ahassani@chromium.org>
Date: Wed Oct 24 23:45:05 2018

update_engine et.al: Prevent library leaks into rootfs

- Uprev bsdiff and puffin:
-- Marking 9999 ebuild for dev-util/puffin as stable.
-- Marking 9999 ebuild for dev-util/bsdiff as stable.
-- Migrated to .gn build files.
-- They are exported as static_library (previously shared library). This allows
   better control and prevents libpuffdiff.so and libbsdiff.so to leak into

   rootfs.
-- Migrate them to EAPI=6 for fun.
-- Export and run *_test instead of *_unittest

- Removes delta_generator ebuild flag from everywhere and just use cros_host

BUG=chromium:891899
BUG= chromium:783883 
TEST=sudo FEATURES=test emerge bsdiff puffin update_engine
CQ-DEPEND=CL:1291835

Change-Id: I4531053d4148cb6b108759660e96799f1367fddf
Reviewed-on: https://chromium-review.googlesource.com/1295293
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/dev-util/bsdiff/bsdiff-9999.ebuild
[rename] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/dev-util/bsdiff/bsdiff-4.3.1-r19.ebuild
[modify] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/dev-util/puffin/puffin-9999.ebuild
[modify] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/chromeos-base/update_engine/update_engine-9999.ebuild
[modify] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/profiles/targets/sdk/package.use
[rename] https://crrev.com/091dcebfd92cc13819e859bc30b670896a02fffb/dev-util/puffin/puffin-1.0.0-r425.ebuild

Sign in to add a comment