New issue
Advanced search Search tips

Issue 891896 link

Starred by 1 user
Status: Assigned
Owner:
pwnall@chromium.org
Cc:
falken@chromium.org
dxie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 737282



Sign in to add a comment

Async Cookie API usage needs to handle restarts

Project Member Reported by jam@chromium.org, Oct 3 
It looks like there are three usages of RestrictedCookieManager in the renderer. It doesn't appear that they listen for connection errors and reestablish a connection if the network process crashes.

Victor said this is behind an origin trial, so it's not urgent but we need to fix it. See network_service_restart_browsertest.cc for sample tests.

Comment 1 by jam@chromium.org, Oct 3

Cc: falken@chromium.org
CC Matt since one of the usages is third_party/blink/renderer/modules/cookie_store/service_worker_global_scope_cookie_store.cc (the other two are third_party/blink/renderer/modules/cookie_store/cookie_store.cc and third_party/blink/renderer/modules/cookie_store/window_cookie_store.cc)

Comment 2 by jam@chromium.org, Oct 3

Components: Internals>Services>Network

Comment 3 by jam@chromium.org, Oct 3

Cc: dxie@chromium.org

Comment 4 by jam@chromium.org, Oct 3

Summary: Async Cookie API usage needs to handle restarts (was: RestrictedCookieManager usage needs to handle restarts)
CookieStoreManager::ListenToCookieChanges also should handle network process restarts. There's an example of how to do this in https://chromium-review.googlesource.com/c/chromium/src/+/1192022

Comment 5 by jam@chromium.org, Oct 11

Labels: Hotlist-KnownIssue
►

Sign in to add a comment