New issue
Advanced search Search tips

Issue 891889 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Google Text to speech crashes on signed out screen

Project Member Reported by dtseng@chromium.org, Oct 3

Issue description

- build chrome with target_os = "chromeos"
- run `chrome --login-manager`
- ctrl+alt+z

result:
no speech

Inspecting the Google tts extension shows that :

NativeClient: NaCl module crashed
 
Status: Started (was: Untriaged)

F1003 22:07:00.951281       1 nacl_tts_data_file_loader.cc:148] Opening local persistent file system failed
Status: Fixed (was: Started)
Reverted regressing change (found via manual bisect).
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1e064e8ba4d9f8b6210fd3a9306627e70a6e2c1

commit a1e064e8ba4d9f8b6210fd3a9306627e70a6e2c1
Author: David Tseng <dtseng@chromium.org>
Date: Thu Oct 04 17:28:22 2018

Revert "Remove unnecessary call to EnableFileSystemInGuestMode"

This reverts commit e0ffa06d84c38ae9043c820766d917745da5b401.

Reason for revert: <INSERT REASONING HERE>
Bug:  891889 

Original change's description:
> Remove unnecessary call to EnableFileSystemInGuestMode
> 
> This call makes no sense. There's no reason that loading the
> speech synthesis component extension should trigger enabling
> the filesystem in guest mode for a related, but entirely different,
> extension (ChromeVox).
> 
> If ChromeVox needs EnableFileSystemInGuestMode, we should be calling
> this from code that loads the ChromeVox component extension, but I suspect
> that it doesn't need it at all.
> 
> As far as I can tell this was accidentally added here as part of a
> refactoring:
>   https://codereview.chromium.org/1162283002
> 
> Note that OnceClosure() would be better, but that'd require a big cleanup
> of many other functions, so I don't want to do that as part of the same
> change.
> 
> Bug: none
> Change-Id: I1f67b78548048fffa9194083b10e0ff5c5aaa863
> Reviewed-on: https://chromium-review.googlesource.com/1246364
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594463}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,rdevlin.cronin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: If18c5fcbdbc6be5b6ce8235afa612597792127ff
Reviewed-on: https://chromium-review.googlesource.com/c/1261960
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596731}
[modify] https://crrev.com/a1e064e8ba4d9f8b6210fd3a9306627e70a6e2c1/chrome/browser/extensions/component_loader.cc

  Bug 891889   is for Google Text to speech crashes on signed out screen
 Bug 878883  is for ChromeVox not speaking on Login screen

Sign in to add a comment