New issue
Advanced search Search tips

Issue 891864 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move the system-wide metrics code to its own file (instead of living of process_metrics.h)

Project Member Reported by sebmarchand@chromium.org, Oct 3

Issue description

There's a lot of system-wide metrics measured by base/process/process_metrics.h , this code should probably be moved to its own file(s), here's what I'm offering:
- Move base/system_monitor/* to base/system/.
- Move the system-wide metrics code out of base/process/process_metrics.h, put it in base/system/system_metrics.h

(the code in system_metrics.h and system_monitor.h could probably be merged at some point).

Then I'll be able to add some new system-wide metrics without adding too much confusion (it'll be more evident that the metric is a system-wide metric).

wdyt?

 
Components: Internals
Are you thinking of things like GetSystemMemoryInfo()?
All I'm proposing here is to move the system-wide metrics out of process_metrics.h :), I'll look at cleaning this API after that (before adding new stuff to it).
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f

commit 0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Oct 05 15:29:27 2018

Move base/system_monitor/* to base/system/

This is a first step in moving the system-wide metric measurement code out of base/process/

TBR: jam@chromium.org, dalecurtis@chromium.org
Bug: 891864
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I615190d5413937640a7bd29b68b18028445e4c88
Reviewed-on: https://chromium-review.googlesource.com/c/1260003
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597136}
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/base/BUILD.gn
[rename] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/base/system/system_monitor.cc
[rename] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/base/system/system_monitor.h
[rename] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/base/system/system_monitor_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/base/test/mock_devices_changed_observer.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/chromeos/audio/cras_audio_handler_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/content/browser/browser_main_loop.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/content/browser/renderer_host/media/media_devices_manager.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/device/gamepad/gamepad_provider.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/audio/win/audio_device_listener_win.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/device_monitors/device_monitor_mac.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/device_monitors/device_monitor_udev.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/device_monitors/system_message_window_win.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/device_monitors/system_message_window_win_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/midi/midi_manager_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/media/midi/midi_manager_win.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/services/audio/device_notifier.h
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/services/audio/device_notifier_unittest.cc
[modify] https://crrev.com/0f56c3cd45f8f89e4e2d9a85d43e7dd79d592b4f/services/audio/service.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4

commit 75a7cdfb81e7294b376b4e5c4f37793c5b816ad4
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Tue Nov 13 23:47:03 2018

Move the base/sys_info* files to base/system/

This is a part of my effort to cleanup our system-wide metric
measurement code.

TBR=wfh@chromium.org,bartfab@chromium.org,jochen@chromium.org,rsesek@chromium.org,kinuko@chromium.org

Bug: 891864
Change-Id: I896b8936d91789ba0e0423f0937cd54c973bfcda
Reviewed-on: https://chromium-review.googlesource.com/c/1327441
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607813}
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/android_webview/browser/net/aw_url_request_context_getter.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/display/display_prefs.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/display/display_util.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/host/ash_window_tree_host.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/shell.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/shutdown_controller.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/BUILD.gn
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/allocator/partition_allocator/partition_alloc_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/allocator/tcmalloc_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/android/statistics_recorder_android.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/android/sys_utils.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/android/sys_utils_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/files/file_util_posix.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/files/memory_mapped_file.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/ios/ios_util.mm
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/lazy_instance_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/mac/mac_util_unittest.mm
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/memory_pressure_monitor_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/memory_pressure_monitor_chromeos_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/platform_shared_memory_region_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/shared_memory_mac_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/shared_memory_region_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/memory/shared_memory_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/metrics/persistent_memory_allocator.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/process/launch_win.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/process/process_metrics_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/process/process_metrics_win.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info.h
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_android.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_chromeos.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_freebsd.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_fuchsia.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_internal.h
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_ios.mm
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_linux.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_mac.mm
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_openbsd.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_posix.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_unittest.cc
[rename] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/system/sys_info_win.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/task/task_scheduler/initialization_util.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/task/task_scheduler/task_scheduler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/test/launcher/test_launcher.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/test/launcher/test_launcher_nacl_nonsfi.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/test/launcher/unit_test_launcher.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/trace_event/trace_log.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/base/win/event_trace_controller_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/cc/tiles/tile_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/android/chrome_startup_flags.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/android/feedback/system_info_feedback_source.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/android/oom_intervention/near_oom_monitor.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/android/oom_intervention/oom_intervention_config.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/android/vr/mailbox_to_surface_bridge.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chrome_content_browser_client_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/arc/screen_capture/arc_screen_capture_bridge.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/boot_times_recorder.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/input_method/input_method_manager_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/input_method/input_method_persistence.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/logging.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/demo_mode/demo_mode_detector.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/demo_mode/demo_session.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/hwid_checker.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/hwid_checker_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/net/network_throttling_observer.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/net/wake_on_wifi_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/app_install_event_logger.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/remote_commands/device_command_reboot_job.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/power/cpu_data_collector.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/power/freezer_cgroup_process_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/scoped_set_running_on_chromeos_for_testing.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/settings/token_encryptor.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/chromeos/system_logs/command_line_log_source.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/diagnostics/recon_diagnostics.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/api/enterprise_hardware_platform/enterprise_hardware_platform_api.h
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/api/terminal/terminal_private_api.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/extension_assets_manager_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/updater/local_extension_cache.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/extensions/webstore_installer_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/feedback/show_feedback_page.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/lifetime/termination_notification.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/media/webrtc/webrtc_text_log_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/android_metrics_provider.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/chrome_feature_list_creator.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/perf/cpu_identity.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/perf/perf_provider_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/persistent_histograms.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/navigation_predictor/navigation_predictor.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/offline_pages/android/load_termination_listener_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/policy/device_management_service_configuration.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/prerender/prerender_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/profiling_host/profiling_process_host.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/resource_coordinator/session_restore_policy.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/safe_browsing/incident_reporting/environment_data_collection.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/sessions/tab_loader.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/android/android_about_app_info.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_localized_strings_provider.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/chromeos/sys_internals/sys_internals_message_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/browser/update_client/chrome_update_query_params_delegate_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/chrome_cleaner/http/http_agent_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/chrome_cleaner/logging/cleaner_logging_service.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/common/channel_info_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/common/chrome_paths.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/common/cloud_print/cloud_print_helpers.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/common/cloud_print/cloud_print_helpers_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/installer/util/install_util.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/service/cloud_print/cloud_print_service_helpers_unittest.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/service/net/service_url_request_context_getter.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/test/chromedriver/commands.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chrome/test/chromedriver/server/http_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromecast/app/cast_test_launcher.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromecast/base/cast_sys_info_android.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromecast/base/cast_sys_info_util_shlib.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromecast/common/cast_content_client.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/accelerometer/accelerometer_reader.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/audio/cras_audio_handler.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/chromeos_paths.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/components/drivefs/fake_drivefs_launcher_client.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/components/nearby/system_clock_impl.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/dbus/services/cros_dbus_service.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/dbus/util/version_loader.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/login/login_state.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b4e5c4f37793c5b816ad4/chromeos/network/host_resolver_impl_chromeos.cc
[modify] https://crrev.com/75a7cdfb81e7294b376b
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment