New issue
Advanced search Search tips

Issue 891857 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 25
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add cros configuration tast testing suite

Project Member Reported by gmeinke@chromium.org, Oct 3

Issue description

Add a new cros tast test for configuration testing
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/289983e5bc316aa0ef4bc887ec59dab763ad4517

commit 289983e5bc316aa0ef4bc887ec59dab763ad4517
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Fri Oct 05 22:43:38 2018

tast-local-tests-cros: add dev-go/cmp to ebuild

Add dev-go/cmp to do deep comparisons of structures from test output and
existing golden database file.

BUG= chromium:891857 
TEST=run tast tests manually

Change-Id: I9634f9a7d25487d43f71041fe4b38ab16ef9d842
Reviewed-on: https://chromium-review.googlesource.com/1259605
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

[modify] https://crrev.com/289983e5bc316aa0ef4bc887ec59dab763ad4517/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69

commit 99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Fri Oct 26 19:14:55 2018

chromeos-config: Add cros_config_test_schema proc

Add new python processing of YAML commands for cros config tast coverage
testing, output JSON as input during build stage.

BUG= chromium:891857 ,  chromium:897753 
TEST=local unit tests

Change-Id: I6eacd74ea607046437c9aa8be77de193bc0ada19
Reviewed-on: https://chromium-review.googlesource.com/1286078
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>

[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/cros_config_test_schema.py
[modify] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/setup.py
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/cros_config_test_schema.yaml
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/test_data/cros_config_test_device.yaml
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/test_data/cros_config_test_common.yaml
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/libcros_schema_unittest.py
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/cros_config_test_schema_unittest.py
[add] https://crrev.com/99ec4d099b358b2fe99d9e35d0c50e4ec12d5f69/chromeos-config/cros_config_host/libcros_schema.py

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/89a6cafe165c2c49e8c7b5f11ca4e747066ae703

commit 89a6cafe165c2c49e8c7b5f11ca4e747066ae703
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Fri Nov 09 22:43:53 2018

chromeos-config: Fix test schema json format

BUG= chromium:891857 ,  chromium:897753 
TEST=local unittests and output format read in tast test

Output json was not pretty printed correctly causing file to be a
string with newline chars instead of actual newlines. This broke
the Golang unmarshal to struct.

Refactored a bunch of cros_config_schema to use the common schema
functions.

Change-Id: I0cf2650050513d8a74693404af24bd55b7aac4f1
Reviewed-on: https://chromium-review.googlesource.com/1312647
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

[modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_schema.py
[modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_test_schema.py
[modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_schema_unittest.py
[modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/cros_config_test_schema_unittest.py
[modify] https://crrev.com/89a6cafe165c2c49e8c7b5f11ca4e747066ae703/chromeos-config/cros_config_host/libcros_schema.py

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d422026af3f6d0a5df6182ee37905305f21e3da2

commit d422026af3f6d0a5df6182ee37905305f21e3da2
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Sat Nov 17 03:50:41 2018

eclass: add new cros-config-test eclass

BUG= chromium:891857 
TEST=local builds and tryjobs
CQ-DEPEND=CL:1312644

Add a new eclass to copy cros-config test files into place for tast
testing.

Change-Id: I0957731b177262d38db4e735f71d8bfdf1a70573
Reviewed-on: https://chromium-review.googlesource.com/1315412
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>

[modify] https://crrev.com/d422026af3f6d0a5df6182ee37905305f21e3da2/eclass/cros-unibuild.eclass
[add] https://crrev.com/d422026af3f6d0a5df6182ee37905305f21e3da2/eclass/cros-config-test.eclass

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e858b8a9e0d8648601b0d6b3843209d87ad4697e

commit e858b8a9e0d8648601b0d6b3843209d87ad4697e
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Sat Nov 17 03:50:41 2018

cros-config-test: add new ebuild

BUG= chromium:891857 
TEST=local builds and tryjobs
CQ-DEPEND=CL:1315412, CL:1312644

Add a new ebuild to merge and copy cros-config test files into
place for tast testing.

Change-Id: I24775377c343fbdce6a8fc79e42681098dc29087
Reviewed-on: https://chromium-review.googlesource.com/1315768
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>

[add] https://crrev.com/e858b8a9e0d8648601b0d6b3843209d87ad4697e/chromeos-base/cros-config-test/cros-config-test-0.0.1-r1.ebuild
[add] https://crrev.com/e858b8a9e0d8648601b0d6b3843209d87ad4697e/chromeos-base/cros-config-test/cros-config-test-0.0.1.ebuild
[add] https://crrev.com/e858b8a9e0d8648601b0d6b3843209d87ad4697e/chromeos-base/cros-config-test/files/cros_config_test_common.yaml

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d32b8a071fa800760002118882c8cbd0003666ef

commit d32b8a071fa800760002118882c8cbd0003666ef
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Sat Nov 17 03:50:42 2018

Add cros-config-test to target-chromium-os-dev

Add a new ebuild cros-config-test to dev/test build images.

BUG= chromium:891857 
TEST=local builds and tryjobs
CQ-DEPEND=CL:1315412

Change-Id: Id490c99200af2b18a6c7f918bbb1cdbae3e8394b
Reviewed-on: https://chromium-review.googlesource.com/1324990
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: C Shapiro <shapiroc@chromium.org>
Reviewed-by: Evan Hernandez <evanhernandez@chromium.org>

[rename] https://crrev.com/d32b8a071fa800760002118882c8cbd0003666ef/virtual/target-chromium-os-dev/target-chromium-os-dev-1-r36.ebuild
[modify] https://crrev.com/d32b8a071fa800760002118882c8cbd0003666ef/virtual/target-chromium-os-dev/target-chromium-os-dev-1.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 18

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 18

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/1c155e67a994f8ea3fa77428e97d468da6e61781

commit 1c155e67a994f8ea3fa77428e97d468da6e61781
Author: Gregory Meinke <gmeinke@chromium.org>
Date: Sun Nov 25 03:21:33 2018

tast-tests: Add new cros_config tast test

BUG= chromium:891857 
TEST=run tast tests manually
CQ-DEPEND=CL:1259605

Design Doc: go/cros-config-test-coverage

Change-Id: I5f633e781c793505e49f8679bf8d2211093b0de7
Reviewed-on: https://chromium-review.googlesource.com/1260056
Commit-Ready: Gregory Meinke <gmeinke@chromium.org>
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/1c155e67a994f8ea3fa77428e97d468da6e61781/src/chromiumos/tast/local/bundles/cros/platform/cros_config.go

Status: Fixed (was: Started)
closing this bug and opening specific ones for the rest of the tasks.

Sign in to add a comment