New issue
Advanced search Search tips

Issue 891841 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 882562



Sign in to add a comment

Swarming bot download uses the wrong remote provided filename

Project Member Reported by ayatane@chromium.org, Oct 3

Issue description

The code for downloading the Swarming bot code started using the wrong filename:

SWARM_ZIP="${WORK_DIR}/swarming_bot.zip"
rm -rf swarming_bot*.zip
curl -sSLOJ -o "${SWARM_ZIP}" "${SWARM_URL}/bot_code?bot_id=${SWARM_BOT_ID}"

It used to download to swarming_bit.zip, but now it's using the URL path basename as the filename: bot_code?bot_id=${SWARM_BOT_ID}

I'm not sure if this is an unintentional regression in Swarming.  In any case I'll patch it up for Skylab.
 
Blocking: 882562
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/d06d79d83682150a1257ba131eb9be3e69f96774

commit d06d79d83682150a1257ba131eb9be3e69f96774
Author: Allen Li <ayatane@chromium.org>
Date: Wed Oct 03 22:21:13 2018

Cc: -mar...@chromium.org
Actually this is just because of a 403 because curl is being stupid.  Going to keep this open for a bit to make the error clearer.
Components: -Infra>Platform>Milo>LUCI
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/6388eb6e944ee4e02f0eedd38abac3a3ff363761

commit 6388eb6e944ee4e02f0eedd38abac3a3ff363761
Author: Allen Li <ayatane@chromium.org>
Date: Thu Oct 04 20:12:31 2018

Status: Fixed (was: Started)

Sign in to add a comment