New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 891836 link

Starred by 1 user
Status: Fixed
Owner:
chiniforooshan@chromium.org
Closed: Oct 4
Cc:
█ nednguyen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

Smoothness unit test is failing

Project Member Reported by chiniforooshan@chromium.org, Oct 3 
  Traceback (most recent call last):
    File "/b/swarming/w/ir/tools/perf/measurements/smoothness_unittest.py", line 85, in testSmoothnessSurfaceFlingerMetricsCalculated
      self.assertEquals(1, len(avg_surface_fps))
  AssertionError: 1 != 0

It's preventing catapult roll. I'll send a fix shortly.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87bb2f9b79ce3b0a592331da4879bdebcc6d859a

commit 87bb2f9b79ce3b0a592331da4879bdebcc6d859a
Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Date: Thu Oct 04 01:30:11 2018

Telemetry: Fix smoothness unit test

The test uses results.FindAllPageSpecificValuesNamed to verify
existence of metrics which does not work for TBMv2 metrics.

Bug:  891836 
Change-Id: Ib1ee4e8081268ad5be846040058db44d013feab3
Reviewed-on: https://chromium-review.googlesource.com/c/1259942
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#596469}
[modify] https://crrev.com/87bb2f9b79ce3b0a592331da4879bdebcc6d859a/tools/perf/measurements/rendering_unittest.py
[modify] https://crrev.com/87bb2f9b79ce3b0a592331da4879bdebcc6d859a/tools/perf/measurements/rendering_util.py
[modify] https://crrev.com/87bb2f9b79ce3b0a592331da4879bdebcc6d859a/tools/perf/measurements/smoothness_unittest.py

Comment 2 by chiniforooshan@chromium.org, Oct 4

Status: Fixed (was: Started)

Comment 3 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment