web::HttpServer is deprecated in favor of net::EmbeddedTestServer https://docs.google.com/document/d/1tTnjQIvN3gaF4iM3NI9NxHM7hBSHiVIBesssJxyq63I/edit?ts=5970bfd9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/749e6c2cd7350826efb7e04914ec2e4c838e091d commit 749e6c2cd7350826efb7e04914ec2e4c838e091d Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Mon Oct 08 09:36:24 2018 [iOS] Disallow include of deprecated server More info: https://docs.google.com/document/d/1tTnjQIvN3gaF4iM3NI9NxHM7hBSHiVIBesssJxyq63I/edit?ts=5970bfd9# BUG: 891834 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibc84b996a5e76f5b387e98669364fbd7221e539f Reviewed-on: https://chromium-review.googlesource.com/c/1258164 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597507} [modify] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/PRESUBMIT.py [modify] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/build/fuchsia/layout_test_proxy/DEPS [modify] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/autofill/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/autofill/automation/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/device_sharing/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/metrics/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/net/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ntp_tiles/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/passwords/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/translate/DEPS [modify] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/activity_services/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/autofill/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/autofill/manual_fill/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/bookmarks/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/find_bar/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/fullscreen/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/history/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/infobars/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/payments/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/popup_menu/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/print/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/qr_scanner/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/reading_list/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/recent_tabs/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/sad_tab/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/settings/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/settings/sync_utils/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/tab_grid/DEPS [modify] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/ui/toolbar/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/browser/web/DEPS [add] https://crrev.com/749e6c2cd7350826efb7e04914ec2e4c838e091d/ios/chrome/test/earl_grey/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0036eb8163137b81d11383ba0351079b4f744693 commit 0036eb8163137b81d11383ba0351079b4f744693 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Tue Oct 09 07:55:41 2018 [iOS] Disallow include of web::HTTPServer This reverts commit 749e6c2cd7350826efb7e04914ec2e4c838e091d. And disallows the include with more specific exceptions. Bug: 891834 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibe145aeadea365badf0ff8142a082d1bc19a7e62 Reviewed-on: https://chromium-review.googlesource.com/c/1268022 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597832} [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/autofill/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/autofill/automation/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/device_sharing/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/metrics/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/net/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ntp_tiles/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/passwords/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/translate/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/activity_services/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/autofill/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/autofill/manual_fill/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/bookmarks/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/find_bar/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/fullscreen/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/history/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/infobars/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/payments/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/popup_menu/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/print/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/qr_scanner/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/reading_list/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/recent_tabs/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/sad_tab/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/settings/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/settings/sync_utils/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/tab_grid/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/ui/toolbar/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/browser/web/DEPS [modify] https://crrev.com/0036eb8163137b81d11383ba0351079b4f744693/ios/chrome/test/earl_grey/DEPS
Comment 1 by eugene...@chromium.org
, Oct 4