shellcheck: patch in support for `local` in POSIX scripts |
||
Issue descriptionuntil upstream makes this more flexible, we'll have to patch in `local` support in shellcheck for POSIX shell scripts per our shell guidelines upstream request: https://github.com/koalaman/shellcheck/issues/1341 once we have it patched locally, we'll need to figure out the tricium side of things too
,
Oct 22
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b05727f475b1f48c58c45ebbf7fb25387f31585c commit b05727f475b1f48c58c45ebbf7fb25387f31585c Author: Benjamin Gordon <bmgordon@chromium.org> Date: Wed Oct 24 20:03:14 2018 shellcheck: Allow local in POSIX scripts Officially, local isn't allowed in POSIX shell scripts, so shellcheck warns about it under SC2039. All the shells we use actually allow it and we make use of it, so we don't want to warn about it. An upstream discussion was started at https://github.com/koalaman/shellcheck/issues/1341, but until that's resolved, we can locally patch out the check. BUG=chromium:891826 TEST=shellcheck src/platform2/init/dev_utils.sh Change-Id: I6b68f98862052facf868a81f645c827ab551860a Reviewed-on: https://chromium-review.googlesource.com/1295291 Commit-Ready: Benjamin Gordon <bmgordon@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/b05727f475b1f48c58c45ebbf7fb25387f31585c/dev-util/shellcheck/files/shellcheck-0.5.0-allowlocal.patch [rename] https://crrev.com/b05727f475b1f48c58c45ebbf7fb25387f31585c/dev-util/shellcheck/shellcheck-0.5.0-r3.ebuild |
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Oct 3