Issue metadata
Sign in to add a comment
|
regression in 69: text input stops accepting keyboard input in ARC KIOSK only |
||||||||||||||||||||||||||||||
Issue descriptionChromeOS version: 69.0.3497.95 ChromeOS device model: any Case#: P1, Description: Starting from version 69, text input doesn't react on any keyboard inputs, in Arc Kiosk (works fine in non-kiosk). Steps to reproduce: 1. Enroll a device to test domain, super admin credentials: https://docs.google.com/document/d/1DlARkgDgWSi5MiOFt4KlelrCn7KnJi_McuM-jATwALI/edit (customer's app is internal and shared to orgID of this test domain only). 2. Move device to igor -> arc_kiosk_app_case_17038203 OU 3. Reboot device, let kiosk run, click on "Activate". Current Behavior / Reproduction: Not able to enter Activation key (per bad-69.mp4) Expected Behavior: Able to enter Activation key (per good-67-68.mp4) Drive link to logs: https://drive.google.com/open?id=1udl5qSGpb0GRmkX5Sj1IyRESxYK4EYUO We are working on bissecting it more precise. So far: 68: Good 69: Bad Don't know if it's related, in logcat I see 09-26 19:34:35.672 71 71 W InputMethodUtils: Found no fallback locale. imis=[] 09-26 19:34:35.672 71 71 W InputMethodUtils: No software keyboard is found. imis=[] fallbackLocale=null 09-26 19:34:35.673 71 71 W InputMethodManagerService: No IME selected. Choose the most applicable IME. 09-26 19:34:35.673 71 71 W InputMethodUtils: Found no fallback locale. imis=[] 09-26 19:34:35.673 71 71 W InputMethodUtils: No software keyboard is found. imis=[] fallbackLocale=null 09-26 19:34:35.673 71 71 I InputMethodManagerService: No default found
,
Oct 3
,
Oct 4
RBS for M-70 since this is impacting one of our large signage customers.
,
Oct 4
Ping on this. We're nearing M70 stable checkpoints. Will this fix make M70?
,
Oct 5
Could you please share which app is used here? Unfortunately, the attached logs are grabbed outside of kiosk session and doesn't have related ARC logs, so first I need to try the app locally.
,
Oct 5
the app is Glink 3270 Enterprise: appId=app:no.gar.eglink3270 https://screenshot.googleplex.com/PiLzGBWH3xy
,
Oct 5
Yuichiro, could you please take a look why keyboard input is ignored in Android app? I was typing something around 13:18:00 in the bugreport. You can reproduce it with Wikipedia app, for example. +jdufault@ and qnnguyen@ in case it's related to changes in the way how ARC kiosk is started - might it be that some "input blocker or etc" is not closed?
,
Oct 5
,
Oct 5
Just as a fyi ... you can make the keyboard work eventually by opening and closing a session a few times from our testing ..... but we also have the key auto applying via config file .... so if you are stuck on the page where you enter the key I am not sure how to force it from there. It is hit and miss but it eventually does work for a little bit.
,
Oct 9
I'll try to repro it today.
,
Oct 9
,
Oct 9
+yusukes@ and fouchal@, FYI.
,
Oct 9
Is there an update from progress today?
,
Oct 9
I couldn't use the credentials in comment 1, so couldn't test this issue on my local machine. It says the password was changed 4 days ago. Anyway, as I haven't hear any similar problems to this issue in normal mode, I guess this issue is related to Kiosk specific code. "input blocker" sounds very related. jdufault@: Can it cause this issue? poromov@: How did you test this issue?
,
Oct 9
Yuichiro, I've sent you credentials for testing account. Press Ctrl+Alt+E and use this credentials to enroll the device. After that you'll have, for example, Wikipedia app to try (in Apps menu on login screen) - the issue is reproducible there as well.
,
Oct 9
Hey Sergey, afaik there is no KIOSK specific code inside ARC++ input stack. So i believe this bug origin lies within aura (like most of these kind of input bug). Could ChromeOS UI team (jdufault@ & qnnguyen@) working on KIOSK could take a looks at this bug instead of Yuichiro?
,
Oct 11
Hi, are we able to get a fix in time for M70 Stable? We're less than a week out.
,
Oct 12
Hello, Has this been identified as a Chrome OS issue or an Application issue at this point? If Chrome OS issue, when is estimated timeline for fix? If Application issue please provide information that can be provided to Vendor to update their application. This is holding our company back from updating a good number of devices past v68 at this time.
,
Oct 16
Someone more familiar with the input stack should take a look at this. I was able to repro pretty easily by adding a @managedchrome.com account and starting slack as the kiosk app. Escape, tab, and enter all work as expected. The input blocker mentioned in comment #7 is destroyed very shortly after it is created and is not used here. I adding some logging to ui::Event::StopPropagation and ui::Event::SetHandled. Nothing in login/kiosk is calling these outside of components/exo/keyboard.cc, so I don't think this is related to login-specific code.
,
Oct 19
I managed to reproduce the issue on my local machine and confirmed this issue. and uploaded a potential fix for this issue, crrev.com/c/1291289
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce37f17db8d3060878b887006e0bfdc41b3eb3c2 commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Mon Oct 22 17:30:45 2018 Fix text input on ARC++ Kiosk apps. We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601631} [modify] https://crrev.com/ce37f17db8d3060878b887006e0bfdc41b3eb3c2/components/arc/ime/arc_ime_service.cc
,
Oct 22
requesting to merge the CL into M-70. The CL changes the code running only on ARC++ Kiosk mode, so it won't break other platforms and normal CrOS.
,
Oct 22
Approved for M70 ChromeOS.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/174e2fffc773047ca25a79e202d96cb134cda023 commit 174e2fffc773047ca25a79e202d96cb134cda023 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Mon Oct 22 22:44:40 2018 Fix text input on ARC++ Kiosk apps. We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) Reviewed-on: https://chromium-review.googlesource.com/c/1295129 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1029} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/174e2fffc773047ca25a79e202d96cb134cda023/components/arc/ime/arc_ime_service.cc
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/174e2fffc773047ca25a79e202d96cb134cda023 Commit: 174e2fffc773047ca25a79e202d96cb134cda023 Author: yhanada@chromium.org Commiter: yhanada@chromium.org Date: 2018-10-22 22:44:40 +0000 UTC Fix text input on ARC++ Kiosk apps. We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) Reviewed-on: https://chromium-review.googlesource.com/c/1295129 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#1029} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 23
Was this confirmed to be a Chrome OS regression? If so do we have a build that this will be available to test in at this time?
,
Oct 25
The fix is in 72.0.3589.0. It's included in Chrome OS 11187.0.0 and ulterior. You can test the fix on latest canary.
,
Oct 25
I'm requesting merge to M-71.
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25
Approving merge to M71 Chrome OS.
,
Oct 25
Is there any way to get this into the M70 release? We wouldn't want to hold back patching for another 6 week patching cycle if it is not 100% required.
,
Oct 26
The patch was merged to M-70 branch also. The next stable release should have it.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d220a88a2510fd4c4a13ffbe67ed4f44d538d03 commit 0d220a88a2510fd4c4a13ffbe67ed4f44d538d03 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Oct 26 01:10:35 2018 Fix text input on ARC++ Kiosk apps. We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) Reviewed-on: https://chromium-review.googlesource.com/c/1300813 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#339} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/0d220a88a2510fd4c4a13ffbe67ed4f44d538d03/components/arc/ime/arc_ime_service.cc
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d220a88a2510fd4c4a13ffbe67ed4f44d538d03 Commit: 0d220a88a2510fd4c4a13ffbe67ed4f44d538d03 Author: yhanada@chromium.org Commiter: yhanada@chromium.org Date: 2018-10-26 01:10:35 +0000 UTC Fix text input on ARC++ Kiosk apps. We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 Test: Can type text on Wikipedia kiosk app. Change-Id: I594aa5c0730704b9ad922441187297bd707de20a Reviewed-on: https://chromium-review.googlesource.com/c/1291289 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) Reviewed-on: https://chromium-review.googlesource.com/c/1300813 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#339} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 26
,
Nov 6
Bug verified on M70 stable 11021.70.0
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07fbe412d6f06d8108602d0b85aba87104652442 commit 07fbe412d6f06d8108602d0b85aba87104652442 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 09 22:46:12 2018 Revert "Fix text input on ARC++ Kiosk apps." This reverts commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2. Reason for revert: Causes crash, see 903671 Original change's description: > Fix text input on ARC++ Kiosk apps. > > We changed IsInArcAppWindow() to use the window property, > aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. > It makes text input on ARC++ Kiosk apps stop working. > This CL adds a temporary workaround for this situation. Ideally, > IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app > correctly. > > Bug: 891825 > Test: Can type text on Wikipedia kiosk app. > Change-Id: I594aa5c0730704b9ad922441187297bd707de20a > Reviewed-on: https://chromium-review.googlesource.com/c/1291289 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601631} TBR=yusukes@chromium.org,yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891825 Change-Id: Ic50a4bac3af3dfb7f8fd335bb669d3e620a4446a Reviewed-on: https://chromium-review.googlesource.com/c/1330339 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607011} [modify] https://crrev.com/07fbe412d6f06d8108602d0b85aba87104652442/components/arc/ime/arc_ime_service.cc
,
Nov 15
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d23e402154f3d8c65cd570f185ea41b4a4f48255 commit d23e402154f3d8c65cd570f185ea41b4a4f48255 Author: Scott Violet <sky@chromium.org> Date: Thu Nov 15 17:16:14 2018 Revert "Fix text input on ARC++ Kiosk apps." This reverts commit 0d220a88a2510fd4c4a13ffbe67ed4f44d538d03. Reason for revert: Causes crash, see 903671 Original change's description: > Fix text input on ARC++ Kiosk apps. > > We changed IsInArcAppWindow() to use the window property, > aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. > It makes text input on ARC++ Kiosk apps stop working. > This CL adds a temporary workaround for this situation. Ideally, > IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app > correctly. > > Bug: 891825 > Test: Can type text on Wikipedia kiosk app. > Change-Id: I594aa5c0730704b9ad922441187297bd707de20a > Reviewed-on: https://chromium-review.googlesource.com/c/1291289 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) > Reviewed-on: https://chromium-review.googlesource.com/c/1300813 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#339} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891825 Change-Id: I240791738a263cd91385b6f915cd741ed1fa855f Reviewed-on: https://chromium-review.googlesource.com/c/1338169 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#693} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/d23e402154f3d8c65cd570f185ea41b4a4f48255/components/arc/ime/arc_ime_service.cc
,
Nov 15
Because of the crash I have reverted in the branch as well.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d23e402154f3d8c65cd570f185ea41b4a4f48255 Commit: d23e402154f3d8c65cd570f185ea41b4a4f48255 Author: sky@chromium.org Commiter: sky@chromium.org Date: 2018-11-15 17:16:14 +0000 UTC Revert "Fix text input on ARC++ Kiosk apps." This reverts commit 0d220a88a2510fd4c4a13ffbe67ed4f44d538d03. Reason for revert: Causes crash, see 903671 Original change's description: > Fix text input on ARC++ Kiosk apps. > > We changed IsInArcAppWindow() to use the window property, > aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. > It makes text input on ARC++ Kiosk apps stop working. > This CL adds a temporary workaround for this situation. Ideally, > IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app > correctly. > > Bug: 891825 > Test: Can type text on Wikipedia kiosk app. > Change-Id: I594aa5c0730704b9ad922441187297bd707de20a > Reviewed-on: https://chromium-review.googlesource.com/c/1291289 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#601631}(cherry picked from commit ce37f17db8d3060878b887006e0bfdc41b3eb3c2) > Reviewed-on: https://chromium-review.googlesource.com/c/1300813 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/branch-heads/3578@{#339} > Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} TBR=yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891825 Change-Id: I240791738a263cd91385b6f915cd741ed1fa855f Reviewed-on: https://chromium-review.googlesource.com/c/1338169 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#693} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 19
Sorry for the breakage. I'm working on re-landing it now.
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d576e9a44fe4c5b6a07e568f1ebc753f1214634 commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Nov 20 01:35:25 2018 Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#609551} [modify] https://crrev.com/5d576e9a44fe4c5b6a07e568f1ebc753f1214634/components/arc/ime/arc_ime_service.cc
,
Nov 20
OK, this is a bit hard to follow. Am I understanding this correctly when I see that this fix was removed due to creating another issue? currently in V70 should this be working or not working? I do not want to allow v70 if this works now but will not work in later releases of 70 or 71.
,
Nov 20
You understanding is correct. M-70 should be OK because the original patch is in it. I'll request merge the retry CL to M-71 after it appears to canary and I confirm it's okay. So, stable release of M-71 will not have this issue.
,
Nov 26
I request merge the CL in Comment 43 into M-71. It was already in M-71 branch and reverted due to crash and I fixed it.
,
Nov 26
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 26
@yhanada, there's an unresolved comment in crrev/c/1291289, comment #43 above. Could you take a look and please resolve it before we approve? Thanks.
,
Nov 26
I updated the comment.
,
Nov 27
Merge approved for ChromeOS M71
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f3cc28b53360f25187d30e9908d92d7d8abdd5c Commit: 9f3cc28b53360f25187d30e9908d92d7d8abdd5c Author: yhanada@chromium.org Commiter: yhanada@chromium.org Date: 2018-11-27 23:58:28 +0000 UTC Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609551}(cherry picked from commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634) Reviewed-on: https://chromium-review.googlesource.com/c/1352079 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#834} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f3cc28b53360f25187d30e9908d92d7d8abdd5c commit 9f3cc28b53360f25187d30e9908d92d7d8abdd5c Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue Nov 27 23:58:28 2018 Reland: Fix text input on ARC++ Kiosk apps. The original CL is crrev.com/c/1291289. It was reverted due to crash. Please see crbug.com/903671 . We changed IsInArcAppWindow() to use the window property, aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. It makes text input on ARC++ Kiosk apps stop working. This CL adds a temporary workaround for this situation. Ideally, IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app correctly. Bug: 891825 , 903671 Test: Can type text on Wikipedia kiosk app. Change-Id: I3e6457ee3dc5f3fdcca35a7acbb007325697ddbd Reviewed-on: https://chromium-review.googlesource.com/c/1339779 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#609551}(cherry picked from commit 5d576e9a44fe4c5b6a07e568f1ebc753f1214634) Reviewed-on: https://chromium-review.googlesource.com/c/1352079 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#834} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/9f3cc28b53360f25187d30e9908d92d7d8abdd5c/components/arc/ime/arc_ime_service.cc
,
Nov 28
Thank you for reviewing the request.
,
Dec 4
Used Wikipedia arc application to verify the bug is not present on M70 and M71 stable. |
|||||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||||
Comment 1 by marchuk@chromium.org
, Oct 3Labels: -Pri-2 Pri-1