Issue metadata
Sign in to add a comment
|
OOBE is loading forever after the user signed in |
||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3570.0 OS: ChromeOS What steps will reproduce the problem? (1) Add a person and sign in with an account (2) The screen keeps displaying "Please wait..." What is the expected result? It should move forward to the next screen (which should be the sync-consent on my Pixelbook). What happens instead? The screen is stuck at the "Please wait..." stage.
,
Oct 3
I'm also hitting this on ToT. cc'ing people who may be able to help. Can anyone comment if this is this related to crbug.com/889600 ?
,
Oct 3
This is actively blocking my and another coworker's work, so I'll investigate this with git bisect. I've already found a previous good build, so it should be easy enough for me to find the culprit CL in about 30 minutes. I'll loop back soon.
,
Oct 3
,
Oct 3
Issue 889600 has been merged into this issue.
,
Oct 3
I've identified the culprit CL: https://chromium-review.googlesource.com/c/chromium/src/+/1254210 Mihai and/or Tim, can you please take a look?
,
Oct 3
,
Oct 3
,
Oct 3
,
Oct 3
Yikes, the culprit CL was also merged to M70 (see crbug.com/890758). The fix to this bug will also need to merged in M70.
,
Oct 3
Will a revert of the CL be sufficient to fix in M70? We're are approaching M70 Stable. Thanks
,
Oct 3
crbug/881081 seems to be the same issue.
,
Oct 3
Issue 881081 has been merged into this issue.
,
Oct 3
,
Oct 4
This is tagged as RBD and RBS. If the revert is the answer can we do that right away to not block dev? What's the delay?
,
Oct 4
It looks like msarda@ (the owner of this bug) is based is Paris and it's the middle of the night there. Is anyone else here familiar with the implications of why crrev/1254210 was so crucial to merge into M70 at the time? Ryan, have you checked whether it's a clean revert on both M70 and master?
,
Oct 4
It's a clean revert on master, but I haven't tried on M-70.
,
Oct 4
I will create a CL to fix this this morning. It is hard for me to test the fix though.
,
Oct 4
Note for future investigation: looking at the code, I think the root of the bug is probably this call: GetTokenService()->LoadCredentials(std::string()); https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc?rcl=72758d92461e238aa314c1ffb6219eab17daf5ae&l=190
,
Oct 4
The CL that fixes the issue is going through CQ now. Please do not revert the old CL as it was a fix for a P0 for M70 as well.
,
Oct 4
CL https://chromium-review.googlesource.com/c/chromium/src/+/1261002 is reviewed and going through CQ now. Hope it will land in 30 mins.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8998f0a1bcd4c9bb18e603ec39ca919ad9778f60 commit 8998f0a1bcd4c9bb18e603ec39ca919ad9778f60 Author: Mihai Sardarescu <msarda@chromium.org> Date: Thu Oct 04 11:20:02 2018 [signin] Do nothing when loading credentials on ChromeOS with no primary account. This CL is a partial revert of chromium-review.googlesource.com/c/chromium/src/+/1254210 as a short-term fix for login issues. Only the ChromeOS changes are reverted, the behavior is not reverted on other platforms. The issue on ChromeOS originates from the fact that LoadCredentials is called with an empty primary account: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc?rcl=72758d92461e238aa314c1ffb6219eab17daf5ae&l=190) For the revert of changes in file chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc: TBR= tengs@chromium.org Bug: 891818 Change-Id: I4a3cebf635ec529225ba9427e04783621aeb2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1261002 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#596590} [modify] https://crrev.com/8998f0a1bcd4c9bb18e603ec39ca919ad9778f60/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc [modify] https://crrev.com/8998f0a1bcd4c9bb18e603ec39ca919ad9778f60/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc [modify] https://crrev.com/8998f0a1bcd4c9bb18e603ec39ca919ad9778f60/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
,
Oct 4
I managed to test this locally and the CL above fixes the issue see in the ChromeOS OOBE. Seeing that this is a big issue for ChromeOS beta release, I am requesting the merge to M70 now (before being able to test it on Canary).
,
Oct 4
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 4
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f87f65bbab415bb70f171d152725c3bf9f8b295 commit 3f87f65bbab415bb70f171d152725c3bf9f8b295 Author: Mihai Sardarescu <msarda@chromium.org> Date: Fri Oct 05 08:13:40 2018 [signin] Do nothing when loading credentials on ChromeOS with no primary account. This CL is a partial revert of chromium-review.googlesource.com/c/chromium/src/+/1254210 as a short-term fix for login issues. Only the ChromeOS changes are reverted, the behavior is not reverted on other platforms. The issue on ChromeOS originates from the fact that LoadCredentials is called with an empty primary account: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc?rcl=72758d92461e238aa314c1ffb6219eab17daf5ae&l=190) For the revert of changes in file chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc: TBR= tengs@chromium.org Bug: 891818 Change-Id: I4a3cebf635ec529225ba9427e04783621aeb2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1261002 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596590}(cherry picked from commit 8998f0a1bcd4c9bb18e603ec39ca919ad9778f60) Reviewed-on: https://chromium-review.googlesource.com/c/1261517 Cr-Commit-Position: refs/branch-heads/3538@{#869} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/3f87f65bbab415bb70f171d152725c3bf9f8b295/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc [modify] https://crrev.com/3f87f65bbab415bb70f171d152725c3bf9f8b295/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc [modify] https://crrev.com/3f87f65bbab415bb70f171d152725c3bf9f8b295/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f87f65bbab415bb70f171d152725c3bf9f8b295 Commit: 3f87f65bbab415bb70f171d152725c3bf9f8b295 Author: msarda@chromium.org Commiter: msarda@chromium.org Date: 2018-10-05 08:13:40 +0000 UTC [signin] Do nothing when loading credentials on ChromeOS with no primary account. This CL is a partial revert of chromium-review.googlesource.com/c/chromium/src/+/1254210 as a short-term fix for login issues. Only the ChromeOS changes are reverted, the behavior is not reverted on other platforms. The issue on ChromeOS originates from the fact that LoadCredentials is called with an empty primary account: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc?rcl=72758d92461e238aa314c1ffb6219eab17daf5ae&l=190) For the revert of changes in file chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc: TBR= tengs@chromium.org Bug: 891818 Change-Id: I4a3cebf635ec529225ba9427e04783621aeb2c5a Reviewed-on: https://chromium-review.googlesource.com/c/1261002 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596590}(cherry picked from commit 8998f0a1bcd4c9bb18e603ec39ca919ad9778f60) Reviewed-on: https://chromium-review.googlesource.com/c/1261517 Cr-Commit-Position: refs/branch-heads/3538@{#869} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
,
Oct 5
Issue 891191 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsgingerrs@chromium.org
, Oct 3