GaiaPasswordReuse event dropped during initial sign-in |
||
Issue descriptionWith the new first-run signup experience, The ChromePasswordProtectionService thinks it successfully logged the reuse event, but it looks like the sync service drops it since the user hasn't yet opted in to sync. OnGaiaPasswordChanged() is called when the password is entered, and it has no way to know that the user_event_service wont actually accept the event. We may want a listener there to be notified when the UES becomes ready.
,
Oct 9
When you say "new first-run signup experience," what exactly are you referring to? The first run flow hasn't changed for a while. We updated the strings/UI a bit with the Dice response changes, but we didn't change any of the internals. Are you referring to the new Dice sign-in flow (which is in the content area, as opposed to the old modal dialogue)? That's been around since...M67, I think? So wouldn't necessarily describe it as "new," but that might be the place you're looking for? :)
,
Oct 10
I'm fairly convinced now that this is not caused by any change in Dice, since I can't reproduce this flow as working back when I landed the original code. Sorry for the false alarm Elias. So to fix this, Markus has https://crrev.com/c/1273138 which should make it possible for the CPPS code to retry if it noticed it's trying to log "sign-in + consent" before the "consent" has happened. I'll need to land follow-up CL after that. |
||
►
Sign in to add a comment |
||
Comment 1 by vakh@chromium.org
, Oct 5