clean-up task deferred from a comment: https://chromium-review.googlesource.com/c/chromium/src/+/1252906/4/chrome/browser/ui/webui/welcome/welcome_ui.cc#112 Basically: it would be cleaner if we just pass |profile| to the nuxEmail/nuxGoogleApps constructors and let themselves initialize the FaviconServiceFactory and BookmarkModelFactory.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bb4c578369ba18dc7b068b8a88402dcf91b208a commit 3bb4c578369ba18dc7b068b8a88402dcf91b208a Author: Scott Chen <scottchen@chromium.org> Date: Wed Oct 31 00:23:31 2018 Nux Onboarding: move FaviconService initialization to handlers. Bug: 891807 Change-Id: I7d630d5736de4c4b33efd958298cb3f941780129 Reviewed-on: https://chromium-review.googlesource.com/c/1300675 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604075} [modify] https://crrev.com/3bb4c578369ba18dc7b068b8a88402dcf91b208a/chrome/browser/ui/webui/welcome/nux/email_handler.cc [modify] https://crrev.com/3bb4c578369ba18dc7b068b8a88402dcf91b208a/chrome/browser/ui/webui/welcome/nux/email_handler.h [modify] https://crrev.com/3bb4c578369ba18dc7b068b8a88402dcf91b208a/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc [modify] https://crrev.com/3bb4c578369ba18dc7b068b8a88402dcf91b208a/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h [modify] https://crrev.com/3bb4c578369ba18dc7b068b8a88402dcf91b208a/chrome/browser/ui/webui/welcome/welcome_ui.cc
Comment 1 by scottchen@chromium.org
, Oct 25Status: Started (was: Available)