Fixed bob URL: https://stainless.corp.google.com/search?view=list&first_date=2018-09-27&last_date=2018-10-03&test=^tast\.vm\.CrostiniFiles%24&build=^R71\-11118\.0\.0%24&status=FAIL&status=ERROR&status=ABORT&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false

Over to Nick to take a look.

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/crostini/crostini_manager.cc?q=OnLxdContainerCreated&sq=package:chromium&g=0&l=1441

CrostiniManager should check the status field of the protobuf included with the signal, since it could have failed. The LxdContainerCreated signal was poorly named on my part.

Assigning to jopra@ for practice (!)

The LxdContainerCreated signal's status field is ignored by CrostiniManager's signal handler OnLxdContainerCreated.
The code should take the status code and assign an appopriate return code for the pending callbacks.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea3f2940e366fba2548d5108d22bed412d58d4d9

commit ea3f2940e366fba2548d5108d22bed412d58d4d9
Author: Josh Pratt <jopra@chromium.org>
Date: Wed Oct 10 03:18:46 2018

Respect status from LxdContainerCreatedSignal

The status can indicate various failures. The old code assumed the
signal always indicates success. New ConciergeClientResult enums
indicate the important results.

Also added a CrostiniManagerResterTest, AbortOnContainerCreatedError which
sets fake_cicerone_client_ to respond with an UNKNOWN error and then
ensures that both the callback was called and the error was passed
through to the callback (after being converted from a
LxdContainerCreatedSignal_Status to a ConciergeClientResult.

Bug:  891805 
Change-Id: I0f0af4fa5aea4da6fd2de1439085cef88cd7b2f2
Reviewed-on: https://chromium-review.googlesource.com/c/1266415
Commit-Queue: Josh Pratt <jopra@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598199}
[modify] https://crrev.com/ea3f2940e366fba2548d5108d22bed412d58d4d9/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/ea3f2940e366fba2548d5108d22bed412d58d4d9/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/ea3f2940e366fba2548d5108d22bed412d58d4d9/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
[modify] https://crrev.com/ea3f2940e366fba2548d5108d22bed412d58d4d9/chromeos/dbus/fake_cicerone_client.cc
[modify] https://crrev.com/ea3f2940e366fba2548d5108d22bed412d58d4d9/chromeos/dbus/fake_cicerone_client.h