New issue
Advanced search Search tips

Issue 891798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Quickly refreshing chrome://certificate-manager crashes chrome

Project Member Reported by pmarko@chromium.org, Oct 3

Issue description

From https://bugs.chromium.org/p/chromium/issues/detail?id=844537#c89 :

I'm on eve R71-11037.0.0.

One weird thing I also noticed, is that if you go to chrome://certificate-manager and hit ctrl+r quickly enough times, Chrome crashes.
 
Cc: jayhlee@google.com
While 11037.0.0 has chrome 70.0.3538.0 which is pretty old (~2018-09-05), it should already have the changes from  bug 787602 .
Cc: hendrich@chromium.org emaxx@chromium.org
Labels: -Pri-2 ReleaseBlock-Stable M-70 Pri-1
Marking as RBS as we're concerned this may be related to crbug.com/844537. Can we get eyes on this while pmarko is on leave?
I will take a look into it today.
But AFAIK we don't have any reports of certificates going missing when chrome crashes, do we? Of course this needs to be fixed, but I believe the root cause for crbug.com/844537 to be something else.
I did not see this crash causing the certificate to be deleted
Cc: -hendrich@chromium.org pmarko@chromium.org
Components: UI>Browser>WebUI
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: hendrich@chromium.org
This is where it crashes: https://cs.chromium.org/chromium/src/content/public/browser/web_ui_message_handler.h?rcl=cc124c8111b278045f0e8e031e4bce10dafad2df&l=123

Stacktrace:
[241017:241017:1009/132155.494581:FATAL:web_ui_message_handler.h(123)] Check failed: IsJavascriptAllowed(). Cannot CallJavascriptFunction before explicitly allowing JavaScript.
#0 0x7fba220d083f base::debug::StackTrace::StackTrace()
#1 0x7fba2202e0c3 logging::LogMessage::~LogMessage()
#2 0x556e1a71d556 _ZN7content19WebUIMessageHandler17FireWebUIListenerIJN4base5ValueES3_EEEvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEDpRKT_
#3 0x556e1a83923e certificate_manager::CertificatesHandler::PopulateTree()
#4 0x556e1a838b6d certificate_manager::CertificatesHandler::CertificatesRefreshed()
...


Conclusion: This should not be related to the disappearing certificate bug. Removing ReleaseBlock-Stable and setting prio=2 again.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbb136bd5d583244c5ae7968eeca9ea6ffe9691c

commit fbb136bd5d583244c5ae7968eeca9ea6ffe9691c
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Tue Oct 09 16:03:19 2018

Fix crash on chrome://certificate-manager reload

This CL fixes a crash where certificates_handler.cc calls
FireWebUIListener() while javascript is disallowed.
There is no code path in certificate_handlers.cc to FireWebUIListener()
without going through Allowjavascript() in line 988, but javascript
might be disallowed from elsewhere
(e.g. MainFrameNavigationObserver::DidFinishNavigation).

Bug:  891798 
Change-Id: Id247bd65da264e3458600f7186d64e20bf04f95c
Reviewed-on: https://chromium-review.googlesource.com/c/1270941
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597931}
[modify] https://crrev.com/fbb136bd5d583244c5ae7968eeca9ea6ffe9691c/chrome/browser/ui/webui/certificates_handler.cc

Status: Fixed (was: Assigned)

Sign in to add a comment