Android video thumbnail: vpx codec hit DCHECK when allocating shared memory. |
||
Issue descriptionChrome Version: 71.0.3569 OS: Android (1) Enable downloadhomev2 feature. (2) Download vp8 video. (3) Open download home, hit a DCHECK in: https://chromium.googlesource.com/chromium/src/+/71.0.3569.1/media/mojo/common/mojo_shared_buffer_video_frame.cc#193 The problem is we pass the strides of in memory video frame to create the mojo shared memory frame. But we allocated memory tightly that actual stride should be no greater the in memory video frame strides.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6123d992a898239427cff7e518638b6a75cdbd7 commit e6123d992a898239427cff7e518638b6a75cdbd7 Author: Xing Liu <xingliu@chromium.org> Date: Thu Oct 04 00:30:07 2018 Android video thumbnail: Fix allocation size for vpx thumbnails. When serializing the in-memory vpx video frame into MojoSharedBufferVideoFrame, we currently don't consider the padding in each plane in YUV frame, but we pass the strides, which will trigger a DCHECK. This CL also allocates the padding in each plane into the shared memory. Alternatively, we may remove the padding when copying data. Bug: 891794 Change-Id: I6a81c8f8afcd8ff063f90523773ba07aac2eb7fa Reviewed-on: https://chromium-review.googlesource.com/c/1260007 Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596441} [modify] https://crrev.com/e6123d992a898239427cff7e518638b6a75cdbd7/media/mojo/common/mojo_shared_buffer_video_frame.cc [modify] https://crrev.com/e6123d992a898239427cff7e518638b6a75cdbd7/media/mojo/common/mojo_shared_buffer_video_frame_unittest.cc
,
Oct 4
|
||
►
Sign in to add a comment |
||
Comment 1 by xingliu@chromium.org
, Oct 3