Enhancements for the chrome://extension-internals page |
|
Issue descriptionFeature description: The chrome://extensions-internals page, which launched in 70 will be enhanced over the next few quarters. Eng owner: dbertoni Product owner: Design doc: https://drive.google.com/open?id=1wYrk_EVzWF_df9OXl2Th0eHlCFlX5CpNqK-8lHg6Z7A Are you planning on experimenting before launch? No Any new strings? No Any implications for Google webservices (i.e. sync, translate)? No Binary size? No Do the existing perf tests exercise all aspects of your new feature(s)? N/A
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/719073e953ab3f06c91574031108c62dbfff6f55 commit 719073e953ab3f06c91574031108c62dbfff6f55 Author: Daniel Bratell <bratell@opera.com> Date: Thu Oct 04 10:16:38 2018 Rename some newly added k...Key constants that broke jumbo builds The new extensions_internals_source.cc code used the same constants as extension_basic_info.cc, and since in some jumbo builds those files compile in the same translation unit, those clashed. This is a quick rename to give the clashing variables unique names to make builds happy again. An alternative solution would be to reuse the variables if they have the same value (the linker will (probably?) merge them anyway so probably no wasted binary size). TBR=dbertoni@chromium.org,rdevlin.cronin@chromium.org Bug: 891788 Change-Id: Ia7342f249c9bb0cdb6697e8be00413879b26d284 Reviewed-on: https://chromium-review.googlesource.com/c/1261104 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#596572} [modify] https://crrev.com/719073e953ab3f06c91574031108c62dbfff6f55/chrome/browser/ui/webui/extensions/extension_basic_info.cc [modify] https://crrev.com/719073e953ab3f06c91574031108c62dbfff6f55/chrome/browser/ui/webui/extensions/extensions_internals_source.cc
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b3d891a41b1f6a1739e0105c222051b0050ee8b commit 1b3d891a41b1f6a1739e0105c222051b0050ee8b Author: David Bertoni <dbertoni@chromium.org> Date: Tue Oct 16 21:52:24 2018 [Extensions] Add new properties for event listeners. Add the "is_lazy," "is_for_service_workers," and "url" properties for event listeners. Bug: 891788 Change-Id: I8cabde8c8a8cf5935b448f1ec64aec25070f660e Reviewed-on: https://chromium-review.googlesource.com/c/1279197 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#600138} [modify] https://crrev.com/1b3d891a41b1f6a1739e0105c222051b0050ee8b/chrome/browser/ui/webui/extensions/extensions_internals_source.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Oct 3