New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 891781 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Remove non-DICE code from Settings WebUI

Project Member Reported by dpa...@chromium.org, Oct 3

Issue description

It seems to me that chrome://flags/#account-consistency flag is not respected in the UI code anymore. Is that accurate? I tried setting it to "Disabled" but Settings still thinks that DICE is enabled.

If that is true, can Settings WebUI be cleaned up? It currently holds several non-DICE codepaths. For example  issue 876661  was caused by such complexity where parts of the code did not account for both cases.


 
Description: Show this description
You can disable dice by selecting "dice fix auth errors" in chrome flags.
We can't delete the code yet, because it's not enabled for eveybody. All new profiles have it, but some existing profiles cannot be easily migrated.
Cc: ew...@chromium.org
Any updates on when can this be started?

Comment 4 by droger@chromium.org, Jan 16 (6 days ago)

Dice is still not enabled for 100% of users, because we still did not force the migration (migration happens opportunistically, when the pre-requisites are met).

I think it's above 90% though and we may force-migrate remaining users soon. We don't have immediate plans to do it though, so I expect this will take at least a couple more releases.

As an additional note, there is now a setting ("Allow Chrome Signin" under privacy & security) to disable chrome signin. This disables Dice, but also removes all signin buttons and related UI. I think it doesn't prevent the removal of pre-Dice code, but has to be taken into account.

Sign in to add a comment