Make 'git cl upload' work from LUCI bot environment |
|||
Issue descriptionLUCI bots don't have .gitcookies (they use custom git credential helper instead that usee LUCI_CONTEXT protocol). 'git cl upload' in many places depends on reading .gitcookies when talking to Gerrit (anywhere where CookiesAuthenticator is mentioned). This code should be either refactored to use Authenticator abstraction (that's already exist implemented for LUCI), or butchered even further to have even more branches to account for LUCI environment case.
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b250ec16d39169c4f7df3f9ae40230934d0f4ddb commit b250ec16d39169c4f7df3f9ae40230934d0f4ddb Author: Vadim Shtayura <vadimsh@chromium.org> Date: Thu Oct 04 00:21:08 2018 [git_cl] Don't check .gitcookies when running on LUCI. This CL basically replaces "skip if is_gce" with "skip if default auth method is not gitcookies". This presumable makes 'git cl' work on LUCI in a consistent manner. Before, it worked only if the LUCI bot happened to also be GCE bot. R=tandrii@chromium.org BUG= 891755 Change-Id: I2caa219a4082438a5e026e728bfb62f46a0c80fd Reviewed-on: https://chromium-review.googlesource.com/c/1260053 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/b250ec16d39169c4f7df3f9ae40230934d0f4ddb/git_cl.py [modify] https://crrev.com/b250ec16d39169c4f7df3f9ae40230934d0f4ddb/gerrit_util.py
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f72b33988e4c2f9423741fd1cc0977f450955cae commit f72b33988e4c2f9423741fd1cc0977f450955cae Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Oct 04 01:51:46 2018 Roll src/third_party/depot_tools 684313d6a319..b250ec16d391 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/684313d6a319..b250ec16d391 git log 684313d6a319..b250ec16d391 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 vadimsh@chromium.org [git_cl] Don't check .gitcookies when running on LUCI. Created with: gclient setdep -r src/third_party/depot_tools@b250ec16d391 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:891755 TBR=agable@chromium.org Change-Id: I3b65bc7a9510860ac30641165980a09b756a61b9 Reviewed-on: https://chromium-review.googlesource.com/c/1260145 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596477} [modify] https://crrev.com/f72b33988e4c2f9423741fd1cc0977f450955cae/DEPS
,
Oct 4
Thanks! Seems to be working, feel free to mark as fixed.
,
Oct 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vadimsh@chromium.org
, Oct 3