New issue
Advanced search Search tips

Issue 891752 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 842233
issue 892253

Blocking:
issue 855267



Sign in to add a comment

Support Resource Loading Hints Preview on redirected URLs

Project Member Reported by dougarnett@chromium.org, Oct 3

Issue description

Support reassessing PreviewsState on redirects including triggering a new 
PreviewsHints::MaybeLoadOptimizationHints() upon redirect to a different 
host.

Expect to leverage NavigationThrottle work in progress by HTTPS Server Previews project.

Also re-enable MAYBE_ResourceLoadingHintsHttpsWhitelistedRedirectToHttps browser test.
 
Is this blocked on previews network servicification?
Blockedon: 842233
yes
Blockedon: 892253
Sounds like a duplicate of  Issue 892253 . But, lets keep this open to verify that resource loading hints preview works correctly with redirects.
Labels: M-72
Cc: sophiechang@chromium.org
Blocking: 855267
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5173f4b19abb21157067aa03c0d2361a095ba110

commit 5173f4b19abb21157067aa03c0d2361a095ba110
Author: Doug Arnett <dougarnett@chromium.org>
Date: Tue Nov 20 03:16:17 2018

[Previews] Add UMA on whether resource hints available for redirects

This provides some visibility on whether we successfully loaded and
found resource loading hints for a redirected navigation. This will
help us see how often redirects are looking for and finding hints
vs. total navigations looking for such hints.

Bug:  891752 
Change-Id: I37d8821c4e4acf4fba37aba3fc14025b7187a3dc
Reviewed-on: https://chromium-review.googlesource.com/c/1340569
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609580}
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.h
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/components/previews/content/previews_content_util.cc
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/components/previews/content/previews_content_util_unittest.cc
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/components/previews/content/previews_user_data.h
[modify] https://crrev.com/5173f4b19abb21157067aa03c0d2361a095ba110/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment