UnicodeEncodeError: 'ascii' codec can't encode characters |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@google.com performance_test_suite failing on multiple builders Builders failed on: - Win 7 Perf: https://ci.chromium.org/buildbot/chromium.perf/Win%207%20Perf - mac-10_13_laptop_high_end-perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/mac-10_13_laptop_high_end-perf - win-10-perf: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-10-perf
,
Oct 3
Both Benchmarks logs Benchmarks shard map links lead to empty LogDog pages.
,
Oct 3
THe only failure is shard #2. THe link to shard #2 output doesn't work because the logs are too long. I will try the isolated out link.
,
Oct 3
The isolated output from there https://chrome-isolated.appspot.com/browse?namespace=default-gzip&hash=d1d8c69dde8f123de7f3e004ddcef37a2b548049 doesn't provide links to any failures.
,
Oct 3
,
Oct 3
The only change that happened between the last successful run and the first failure is crrev.com/595521, which seems completely unrelated.
,
Oct 3
Ah, it's this bug:
on trace
Traceback (most recent call last):
File "c:\b\s\w\ir\testing\scripts\run_telemetry_benchmark_as_googletest.py", line 137, in run_benchmark
rc = test_env.run_command_with_output(cmd, env=env, stdoutfile=stdoutfile)
File "c:\b\s\w\ir\testing\scripts\..\test_env.py", line 187, in run_command_with_output
sys.stdout.write(reader.read())
UnicodeEncodeError: 'ascii' codec can't encode characters in position 253-254: ordinal not in range(128)
Traceback (most recent call last):
File "..\..\testing\scripts\run_performance_tests.py", line 277, in <module>
sys.exit(main())
File "..\..\testing\scripts\run_performance_tests.py", line 253, in main
False, stories=stories) or return_code)
File "..\..\testing\scripts\run_performance_tests.py", line 132, in execute_benchmark
args, per_benchmark_args, is_histograms))
File "c:\b\s\w\ir\testing\scripts\run_telemetry_benchmark_as_googletest.py", line 176, in run_benchmark
if rc == 0:
UnboundLocalError: local variable 'rc' referenced before assignment
Failed to delete c:\b\s\w\ir (42 files remaining).
Maybe the test has a subprocess outliving it.
Sleeping 2 seconds.
,
Oct 3
,
Oct 3
The real error seems to be
Traceback (most recent call last):
File "c:\b\s\w\ir\testing\scripts\run_telemetry_benchmark_as_googletest.py", line 137, in run_benchmark
rc = test_env.run_command_with_output(cmd, env=env, stdoutfile=stdoutfile)
File "c:\b\s\w\ir\testing\scripts\..\test_env.py", line 187, in run_command_with_output
sys.stdout.write(reader.read())
UnicodeEncodeError: 'ascii' codec can't encode characters in position 253-254: ordinal not in range(128)
,
Oct 3
Also, I'm getting my logs from here: https://chrome-swarming.appspot.com/task?id=405246d3fd2bb810&refresh=10&show_raw=1 It just takes a really long time for them to load.
,
Oct 3
The problematic UNICODE character is '“'
,
Oct 3
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48142096a60f26a702039a263731a35e4456fdf3 commit 48142096a60f26a702039a263731a35e4456fdf3 Author: Ned Nguyen <nednguyen@google.com> Date: Wed Oct 03 22:17:19 2018 [testing/test_env.py] Use utf-8 encoding for reading test log Bug: 891747 Change-Id: I73142c8bb5c4bbc78da71f230188e33d548a3dab Reviewed-on: https://chromium-review.googlesource.com/c/1259475 Commit-Queue: Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#596397} [modify] https://crrev.com/48142096a60f26a702039a263731a35e4456fdf3/testing/test_env.py
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f43ff6f4cbe7667988389c34edf5dca51d934aa commit 7f43ff6f4cbe7667988389c34edf5dca51d934aa Author: Ned Nguyen <nednguyen@google.com> Date: Thu Oct 04 04:58:46 2018 [testing/test_env.py] Update run_command_with_output to use rb and wb for processing log This is based on Dirk's comment in https://chromium-review.googlesource.com/c/chromium/src/+/1259475#message-01cdaf3daae02840bb55b523a0eb71c9201adade TBR=dpranke@chromium.org, jbudorick@chromium.org Bug: 891747 Change-Id: Iec031e348d26d77de3f897641f4a151d0b4f544d Reviewed-on: https://chromium-review.googlesource.com/c/1260519 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#596509} [modify] https://crrev.com/7f43ff6f4cbe7667988389c34edf5dca51d934aa/testing/test_env.py
,
Oct 5
This error no longer happen, so I think it's fixed
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by crouleau@chromium.org
, Oct 3