Animations are ticked before updating their state. |
||
Issue descriptionThe current cc animation infrastructure calls AnimationHost::TickAnimations before calling AnimationHost::UpdateAnimationState. This seems to tick animations based on their run_state_ from the previous animation tick. This hasn't been a problem for the previous layer based animations since layers informed the animation when they went away but with BlinkGenPropertyTrees we try to tick fill-forwards animations for one more frame after they finished but BGPT no longer creates a composited element / transform node for the animation. This seems to be the cause for the failing LayoutTests that were worked around by removing the thought to be unnecessary AnimateLayers call in https://chromium-review.googlesource.com/c/chromium/src/+/1091504 which revealed that AnimateLayers is necessary to mark finished animations causing issue 888260 . I think we should switch the order of these two calls - this also requires passing in the frame time (currently uses last tick time) and separating out the |start_ready_animations| behavior as this needs to be done later for compositor side animations.
,
Oct 5
,
Nov 16
|
||
►
Sign in to add a comment |
||
Comment 1 by flackr@chromium.org
, Oct 3