Regression:[NTP]Size of the grey shadow(on mouse hover) and the blue focus ring does not match
Reported by
vineetha...@etouch.net,
Oct 3
|
|||||
Issue descriptionChrome version : 70.0.3538.45 (Official Build) Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}(32/64-bit) OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS) OS Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags. Steps to reproduce: 1. Launch chrome, navigate to 'https://chrome.google.com/webstore/category/themes?hl=en' and apply any theme to Chrome. 2. Open NTP and press tab to get blue focus ring on any of the available shortcuts. 3. While the blue focus ring is visible for a shortcut also hover the mouse on that shortcut and observe. Actual Result :Size of the grey shadow(on mouse hover) and the blue focus ring does not match. Expected Result:Grey shadow(mouse hover effect) should completely fill the blue focus ring area. This is a regression issue broken in ‘M-70’ and below is bisect info. Good build: 70.0.3514.0(Revision: 580791) Bad build : 70.0.3515.0(Revision: 581084) Chromium bisect info: You are probably looking for a change made after 580948 (known good), but no later than 580951 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/631ac11aae294abc8b5a100a09e59af59aa6e229..054e04efa5eb96c8ab764ddf54d4afdc22c519bf Suspecting: https://chromium.googlesource.com/chromium/src/+/c2111e0695751dcd6833f86930ea7905daef9494 @kristipark: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: 1.Tried per revision bisect on Windows ,Mac and Linux OS but unable to perform the same since getting following errors, (a)'Traceback error' is thrown on Mac OS and (b)'We do not have enough builds to bisect' is thrown on Windows,Linux OS, hence providing chromium bisect 2.Issue is also reproducible on latest Canary #71.0.3569.0 Thank You
,
Oct 3
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593bed0bab2e5c27d8c77fc33d68ccf8ffbf3c70 commit 593bed0bab2e5c27d8c77fc33d68ccf8ffbf3c70 Author: Kristi Park <kristipark@chromium.org> Date: Thu Oct 04 19:21:59 2018 [NTP] Fix tile padding when theme is enabled The title pill adds 2*4px of vertical padding, which expanded the focus ring size. Bug: 891680 Change-Id: I9c0639f8e759e86350ab6cdb5c72f43f88b21ade Reviewed-on: https://chromium-review.googlesource.com/c/1259834 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596799} [modify] https://crrev.com/593bed0bab2e5c27d8c77fc33d68ccf8ffbf3c70/chrome/browser/resources/local_ntp/most_visited_single.css
,
Oct 4
,
Oct 5
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14.1) and Linux(14.04 LTS)OS with Canary version #71.0.3571.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Nov 9
Does not need to be added to remote NTP |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kristip...@chromium.org
, Oct 3