New issue
Advanced search Search tips

Issue 891662 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 10
Cc:
ajha@chromium.org
rbpotter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Unnecessary Print/Save page is done when we hit enter on the checkboxes of Options

Project Member Reported by rkalavakuntla@chromium.org, Oct 3 
Chrome Version:70.0.3538.41/11021.34.0 beta channel Kip,Reks,Daisy
OS:Chrome OS

What steps will reproduce the problem?
(1)Launch chrome, Press Ctrl+P for Print preview
(2)By tabbing,bring the focus on the checkboxes of Options >>Hit Enter and observe

ACtual: Unnecessary Print/Save page is done when we hit enter on the checkboxes of Options
Expected: Check/Uncheck action should be done when we hit enter on the checkboxes of Options

This is a Non-Regression issue seen from M-62

Note: Issue is also seen with New Print preview UI

Attached the screencast for reference..
Actual.mp4
14.6 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c8e762aa6cda893bda9c12ce0432a43490084f

commit 68c8e762aa6cda893bda9c12ce0432a43490084f
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Oct 04 18:36:00 2018

Print Preview: Fix some print on enter issues

Don't print on enter if a checkbox is focused, or if a child dialog is
open.

Bug:  891662 
Change-Id: I01964016b55503e3f530df17a98ee2e73417180b
Reviewed-on: https://chromium-review.googlesource.com/c/1259616
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596772}
[modify] https://crrev.com/68c8e762aa6cda893bda9c12ce0432a43490084f/chrome/browser/resources/print_preview/new/app.js

Comment 2 by thestig@chromium.org, Oct 10

Owner: rbpotter@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment