New issue
Advanced search Search tips

Issue 891660 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup



Sign in to add a comment

StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup is flaky

Project Member Reported by Findit, Oct 3

Issue description


Flaky test: StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=405248c3fd5b4410
Test output log: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3840
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I69de884b4d270da4d4cc358fe225255b3d4cb3b5
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzg0MC9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVTNSaGNuUjFjRWx1WTI5bmJtbDBiMEp5YjNkelpYSkRjbVZoZEc5eVZHVnpkQzVKYm1OdloyNXBkRzlUZEdGeWRIVndWR2hsYms1dmNtMWhiRk4wWVhKMGRYQT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKvAWNocm9taXVtLmxpbnV4L2xpbnV4LXhlbmlhbC1yZWwvMzg0MC9uZXR3b3JrX3NlcnZpY2VfYnJvd3Nlcl90ZXN0cyBvbiBVYnVudHUtMTYuMDQvVTNSaGNuUjFjRWx1WTI5bmJtbDBiMEp5YjNkelpYSkRjbVZoZEc5eVZHVnpkQzVKYm1OdloyNXBkRzlUZEdGeWRIVndWR2hsYms1dmNtMWhiRk4wWVhKMGRYQT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/046795725952ee27b347155b3e66d006683b990c

commit 046795725952ee27b347155b3e66d006683b990c
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Oct 03 11:44:48 2018

Revert "The session restore logic is improved."

This reverts commit 051435e2710b7958b9fa4a25682da3a1f93b1291.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 596148 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDUxNDM1ZTI3MTBiNzk1OGI5ZmE0YTI1NjgyZGEzYTFmOTNiMTI5MQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/3840

Sample Failed Step: network_service_browser_tests on Ubuntu-16.04

Sample Flaky Test: StartupIncognitoBrowserCreatorTest.IncognitoStartupThenNormalStartup

Original change's description:
> The session restore logic is improved.
> 
> The session restore logic looked at the command line of the main browser
> process, which resulted in session loss if the browser is first launched
> as incognito and then another window is opened with some normal profile.
> 
> This change introduces passing the command line of the new process to
> the session restore point so it decides whether to restore the session
> according to settings and command line both relevant to the profile that
> is to be loaded.
> 
> R=sky@chromium.org
> 
> Change-Id: I69de884b4d270da4d4cc358fe225255b3d4cb3b5
> Reviewed-on: https://chromium-review.googlesource.com/c/1245368
> Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596148}

Change-Id: I543e0412a0960c0a540d8c1dd6dd870dbdc62fa5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891660
Reviewed-on: https://chromium-review.googlesource.com/c/1258387
Cr-Commit-Position: refs/heads/master@{#596182}
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/app_controller_mac.mm
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/sessions/session_service.h
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/046795725952ee27b347155b3e66d006683b990c/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Cc: voo...@yandex-team.ru
Labels: -Pri-1 -Sheriff-Chromium Pri-3
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Removing from sheriff queue as no longer flaking (test no longer exists). Assigning to sky@ as an FYI, feel free to close the bug or repurpose for your tracking uses.

Sign in to add a comment