Regression : [NTP]Unable to perform 'Back page navigation' on pressing 'Space bar' key.
Reported by
rp...@etouch.net,
Oct 3
|
|||
Issue descriptionChrome Version: 71.0.3569.0 (Official Build)Revision fb87327b9e0a0a50c96e084943e5525c25f76fd1-refs/branch-heads/3569@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14.1, 10.13.6) and Linux(14.04 LTs) Pre condition : Enable 'Google local NTP' , 'New Tab Page Custom Links' and 'New Tab Page Background Selection' from chrome://flags. What steps will reproduce the problem? 1. Freshly Launch chrome, open NTP and click on gear icon and select 'Chrome backgrounds' 2. Now click on any collection and bring focus on 'Back navigation' arrow icon and then press 'Space bar' key, observe Actual Result: Unable to perform 'Back page navigation' on pressing 'Space bar' key Expected Result: Should be able to perform 'Back page navigation' on pressing 'Space bar' key This is regression issue broken in ‘M-71’ and will soon update other info: Good build: 71.0.3563.0 (Revision: 594643) Bad build : 71.0.3564.0 (Revision: 594949) You are probably looking for a change made after 594906 (known good), but no later than 594912 (first known bad). Narrow Bisect info: https://chromium.googlesource.com/chromium/src/+log/7b45920dd440fb01675d6a0957a9a512c0c630fc..b7c87c15bf0a5e717c343c8195d93c3960cd7757?pretty=fuller&n=50 Suspect: r594909 ? @kmilka: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1.Providing suspect through 'chromium bisect' script,unable to perform bisect using 'per-revision' as it is giving following errors : (a)"RuntimeError: We don't have enough builds to bisect" error message is thrown on Mac os and (b)Unable to find local data files error is thrown on Windows,Linux OS Thank you.
,
Oct 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dca7db9e4253fe7c325e25b3167034fae068e063 commit dca7db9e4253fe7c325e25b3167034fae068e063 Author: Kyle Milka <kmilka@chromium.org> Date: Wed Oct 03 22:16:02 2018 [NTP] Allow space to be used on the back arrow In https://crrev.com/c/1249834 the tabbable element was changed from a button to role=button so using space to press it no longer worked. Bug: 891652 Change-Id: I8dd7155de5deba6f2b25c3ba5cb39761f84eafdc Reviewed-on: https://chromium-review.googlesource.com/c/1258880 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#596396} [modify] https://crrev.com/dca7db9e4253fe7c325e25b3167034fae068e063/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Oct 3
,
Oct 4
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14.1) using latest Canary build : 71.0.3570.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!! |
|||
►
Sign in to add a comment |
|||
Comment 1 by kmilka@chromium.org
, Oct 3