New issue
Advanced search Search tips

Issue 891641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Flaky-Test: FolderShortcuts/FilesAppBrowserTest.Test



Sign in to add a comment

FolderShortcuts/FilesAppBrowserTest.Test?* is flaky

Project Member Reported by Findit, Oct 3

Issue description


Flaky test: FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4051a3754b671210
Test output log: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29332
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I8ddcbd75b74258b6988ad5c70c4e70c707d18f70
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKuAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5MzMyL3Zpel9icm93c2VyX3Rlc3RzL1JtOXNaR1Z5VTJodmNuUmpkWFJ6TDBacGJHVnpRWEJ3UW5KdmQzTmxjbFJsYzNRdVZHVnpkQzkwY21GMlpYSnpaVVp2YkdSbGNsTm9iM0owWTNWMGMxOUVjbWwyWlVaegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy5QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKuAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI5MzMyL3Zpel9icm93c2VyX3Rlc3RzL1JtOXNaR1Z5VTJodmNuUmpkWFJ6TDBacGJHVnpRWEJ3UW5KdmQzTmxjbFJsYzNRdVZHVnpkQzkwY21GMlpYSnpaVVp2YkdSbGNsTm9iM0owWTNWMGMxOUVjbWwyWlVaegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149

commit 01cdc83d16a773f6d9a1c09a5f86f0d5acc93149
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Wed Oct 03 10:02:03 2018

Revert "Run more FilesApp tests with DriveFS enabled."

This reverts commit 0780e76b03882d92ec8b9b73422783309c6cec57.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 596048 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDc4MGU3NmIwMzg4MmQ5MmVjOGI5YjczNDIyNzgzMzA5YzZjZWM1Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29332

Sample Failed Step: viz_browser_tests

Sample Flaky Test: FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs

Original change's description:
> Run more FilesApp tests with DriveFS enabled.
> 
> Run with DriveFS enabled:
> - Drive-related context_menu.js tests.
> - Drive-related metadata.js tests.
> - folder_shortcuts.js tests.
> - fileDisplayDrive in tablet mode with DriveFS enabled.
> 
> In order to make those tests pass:
> - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return
>   it in GetMetadata().
> - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching
>   metadata, trying to get a value for it.
> - Remove two unused and incomplete tests in context_menu.js.
> - Only perform early-init for the downloads volume for the "user"
>   profile.
> 
> Bug: 891197
> Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70
> Reviewed-on: https://chromium-review.googlesource.com/c/1255086
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596048}

Change-Id: I918211f80347a93388965b5278c2e3b55d4bfca5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891197,  891641 
Reviewed-on: https://chromium-review.googlesource.com/c/1258616
Cr-Commit-Position: refs/heads/master@{#596172}
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/chromeos/components/drivefs/fake_drivefs.cc
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/chromeos/components/drivefs/fake_drivefs.h
[modify] https://crrev.com/01cdc83d16a773f6d9a1c09a5f86f0d5acc93149/ui/file_manager/integration_tests/file_manager/context_menu.js

Project Member

Comment 2 by Findit, Oct 3


Flaky test: FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs
Test output log: https://chromium-swarm.appspot.com/task?id=405254d20a2c0010
Findit identified the culprit r596048 with confidence 100.0% for the example failed
build https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8146 based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzgxNDYvdml6X2Jyb3dzZXJfdGVzdHMvUm05c1pHVnlVMmh2Y25SamRYUnpMMFpwYkdWelFYQndRbkp2ZDNObGNsUmxjM1F1VkdWemRDOTBjbUYyWlhKelpVWnZiR1JsY2xOb2IzSjBZM1YwYzE5RWNtbDJaVVp6DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20FolderShortcuts/FilesAppBrowserTest.Test/traverseFolderShortcuts_DriveFs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKeAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzgxNDYvdml6X2Jyb3dzZXJfdGVzdHMvUm05c1pHVnlVMmh2Y25SamRYUnpMMFpwYkdWelFYQndRbkp2ZDNObGNsUmxjM1F1VkdWemRDOTBjbUYyWlhKelpVWnZiR1JsY2xOb2IzSjBZM1YwYzE5RWNtbDJaVVp6DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Labels: -Pri-1 -Sheriff-Chromium Pri-3
Owner: sa...@chromium.org
Status: Assigned (was: Untriaged)
Removing from sheriff queue as no long flaky after revert (the test no longer exists). Assigning to original CL author; feel free to close or repurpose for your own tracking.
Status: Fixed (was: Assigned)
Deflaked and relanded in r596413.

Sign in to add a comment