Content attribute is created for text |
||||||||
Issue descriptionOnly Element and window can create content attribute. but JSEventHandlerForContentAttribute::GetCompiledHandler() is called with a text type target. You can check this issue with a Webkit unit test, WebViewTest.LongPressSelection .
,
Oct 9
,
Oct 11
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bda23a6a30fbc032054da4426cd93070907b290 commit 7bda23a6a30fbc032054da4426cd93070907b290 Author: Yuki Shiino <yukishiino@chromium.org> Date: Mon Dec 10 15:03:28 2018 v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615116} [modify] https://crrev.com/7bda23a6a30fbc032054da4426cd93070907b290/third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc [modify] https://crrev.com/7bda23a6a30fbc032054da4426cd93070907b290/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e68f6014371c9b1672cd3b063ad0dfb5a8ccf01 commit 9e68f6014371c9b1672cd3b063ad0dfb5a8ccf01 Author: Yuki Shiino <yukishiino@chromium.org> Date: Mon Dec 10 15:19:59 2018 v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615116}(cherry picked from commit 7bda23a6a30fbc032054da4426cd93070907b290) Reviewed-on: https://chromium-review.googlesource.com/c/1370146 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/branch-heads/3636@{#3} Cr-Branched-From: 6b4d81b2d610bba6e691389b2ef771db17c40498-refs/heads/master@{#615028} [modify] https://crrev.com/9e68f6014371c9b1672cd3b063ad0dfb5a8ccf01/third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc [modify] https://crrev.com/9e68f6014371c9b1672cd3b063ad0dfb5a8ccf01/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa commit 9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa Author: Yuki Shiino <yukishiino@chromium.org> Date: Mon Dec 10 21:20:12 2018 v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615116}(cherry picked from commit 7bda23a6a30fbc032054da4426cd93070907b290) Reviewed-on: https://chromium-review.googlesource.com/c/1370489 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#236} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa/third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc [modify] https://crrev.com/9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcfa1803d4408370e3b1a187b84d4a6b620f491a commit dcfa1803d4408370e3b1a187b84d4a6b620f491a Author: Yuki Shiino <yukishiino@chromium.org> Date: Mon Dec 10 21:21:32 2018 v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615116}(cherry picked from commit 7bda23a6a30fbc032054da4426cd93070907b290) Reviewed-on: https://chromium-review.googlesource.com/c/1370828 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#889} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/dcfa1803d4408370e3b1a187b84d4a6b620f491a/third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc [modify] https://crrev.com/dcfa1803d4408370e3b1a187b84d4a6b620f491a/third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcfa1803d4408370e3b1a187b84d4a6b620f491a Commit: dcfa1803d4408370e3b1a187b84d4a6b620f491a Author: yukishiino@chromium.org Commiter: govind@chromium.org Date: 2018-12-10 21:21:32 +0000 UTC v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615116}(cherry picked from commit 7bda23a6a30fbc032054da4426cd93070907b290) Reviewed-on: https://chromium-review.googlesource.com/c/1370828 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#889} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa Commit: 9bea27c0383b8f83df4b90c9c59e81c7a62bf5fa Author: yukishiino@chromium.org Commiter: govind@chromium.org Date: 2018-12-10 21:20:12 +0000 UTC v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310 , 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615116}(cherry picked from commit 7bda23a6a30fbc032054da4426cd93070907b290) Reviewed-on: https://chromium-review.googlesource.com/c/1370489 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#236} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by yukiy@google.com
, Oct 3